From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 1/6] hwmon: (lm92) Improve auto-detection accuracy
Date: Fri, 2 Aug 2024 05:11:54 +0000 [thread overview]
Message-ID: <Zqxqmkuqd1K1oUlK@google.com> (raw)
In-Reply-To: <20240801144918.6156-2-linux@roeck-us.net>
On Thu, Aug 01, 2024 at 07:49:13AM -0700, Guenter Roeck wrote:
> Checking three configuration register bits and the manufacturer ID
> register to auto-detect LM92 is a bit vague. Repeat twice on replicated
> register addresses to improve detection accuracy. Check the manufacturer
> ID first and bail out immediately without reading the other register if
> there is a mismatch to reduce the number of i2c transfers needed in that
> case. Also explicitly test for an error from reading the configuration
> register to avoid potential situations where the returned error masked
> against 0xe0 is 0.
>
> While at it, drop "lm92: Found National Semiconductor LM92 chip" detection
> noise.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2024-08-02 5:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 14:49 [PATCH 0/6] hwmon: (lm92) Cleanup and conversion to with_info API Guenter Roeck
2024-08-01 14:49 ` [PATCH 1/6] hwmon: (lm92) Improve auto-detection accuracy Guenter Roeck
2024-08-02 5:11 ` Tzung-Bi Shih [this message]
2024-08-01 14:49 ` [PATCH 2/6] hwmon: (lm92) Reorder include files to alphabetic order Guenter Roeck
2024-08-02 5:12 ` Tzung-Bi Shih
2024-08-01 14:49 ` [PATCH 3/6] hwmon: (lm92) Replace chip IDs with limit register resolution Guenter Roeck
2024-08-02 5:12 ` Tzung-Bi Shih
2024-08-01 14:49 ` [PATCH 4/6] hwmon: (lm92) Convert to use regmap Guenter Roeck
2024-08-02 5:12 ` Tzung-Bi Shih
2024-08-01 14:49 ` [PATCH 5/6] hwmon: (lm92) Convert to with_info hwmon API Guenter Roeck
2024-08-02 5:12 ` Tzung-Bi Shih
2024-08-01 14:49 ` [PATCH 6/6] hwmon: (lm92) Update documentation Guenter Roeck
2024-08-02 5:12 ` Tzung-Bi Shih
2024-08-02 14:11 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqxqmkuqd1K1oUlK@google.com \
--to=tzungbi@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox