public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Eckert <fe@dev.tdt.de>
To: Rob Herring <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	jdelvare@suse.com
Subject: Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
Date: Wed, 13 Sep 2017 07:36:16 +0200	[thread overview]
Message-ID: <a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de> (raw)
In-Reply-To: <20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>

Hello Rob

>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
>> > @@ -0,0 +1,10 @@
>> > +Lantiq cpu temperatur sensor
> 
> s/temperatur/temperature/

Will update this in a follow up page based on the old one. So no v4?

> 
>> > +
>> > +Requires node properties:
>> > +- compatible value :
>> > +	"lantiq,cputemp"
> 
> Kind of non-specific. How is this device even accessed without any 
> other
> property?

It does not need any further properties. If this is set in the device 
tree then the driver is loaded.
After loading the temperature could be read from "/sys/class/hwmon".

Let me know what should i do to get this fixed?

Thanks for feedback

Florian


  reply	other threads:[~2017-09-13  5:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01  6:58 [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
2017-09-01  6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
2017-09-01 14:26   ` Guenter Roeck
2017-09-12 16:20     ` Rob Herring
2017-09-13  5:36       ` Florian Eckert [this message]
2017-09-13 14:12         ` Guenter Roeck
2017-09-13 14:42           ` Florian Eckert
2017-09-13 15:12             ` Guenter Roeck
2017-09-13 15:25         ` Rob Herring
2017-09-14  7:06           ` Florian Eckert
2017-09-20  2:53             ` Rob Herring
2017-09-13 14:12       ` Guenter Roeck
2017-09-01 14:24 ` [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de \
    --to=fe@dev.tdt.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox