Re: [PATCH 3/4] arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device

Manaf Meethalavalappu Pallikunhi
2026-02-13T11:55:34Z

Hi Konrad,

On 2/6/2026 2:41 PM, Konrad Dybcio wrote:
> On 2/5/26 10:14 PM, Manaf Meethalavalappu Pallikunhi wrote:
>> Enable Qualcomm BCL hardware devicetree binding configuration
>> for pm7250b.
>>
>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
>> index 0761e6b5fd8d..69ad76831cde 100644
>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
>> @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> +
>> + bcl@1d00 {
>> + compatible = "qcom,pm7250b-bcl", "qcom,bcl-v1";
>> + reg = <0x1d00>;
>> + interrupts = <PM7250B_SID 0x1d 0x0 IRQ_TYPE_EDGE_RISING>,
>> + <PM7250B_SID 0x1d 0x1 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "bcl-max-min",
>> + "bcl-critical";
> We should strip the "bcl-" prefix, since these interrupts happen
> to be under the bcl device
Ack
>
>> + overcurrent-thresholds-milliamp = <5500 6000>;
> Is that something that we expect to change between boards, or is
> that an electrical characteristic of the PM7250B?
Yes,  It can change based on battery used for that board as these
thresholds will be close below battery OCP spec.
It is not based on pmic spec. Max current threshold support for specific
pmic bcl is taken care in driver pmic data.

Thanks,
Manaf
>
> Konrad