From: Guenter Roeck <linux@roeck-us.net>
To: "Ваторопин Андрей" <a.vatoropin@crpt.ru>
Cc: Jean Delvare <jdelvare@suse.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH v2] hwmon: (xgene-hwmon) use appropriate type for the latency value
Date: Thu, 6 Feb 2025 18:52:54 -0800 [thread overview]
Message-ID: <aedbefb8-7979-4482-a2af-e12eda4a4b6f@roeck-us.net> (raw)
In-Reply-To: <20250204095400.95013-1-a.vatoropin@crpt.ru>
On Tue, Feb 04, 2025 at 09:54:08AM +0000, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@crpt.ru>
>
> The expression PCC_NUM_RETRIES * pcc_chan->latency is currently being
> evaluated using 32-bit arithmetic.
>
> Since a value of type 'u64' is used to store the eventual result,
> and this result is later sent to the function usecs_to_jiffies with
> input parameter unsigned int, the current data type is too wide to
> store the value of ctx->usecs_lat.
>
> Change the data type of "usecs_lat" to a more suitable (narrower) type.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2025-02-07 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:54 [PATCH v2] hwmon: (xgene-hwmon) use appropriate type for the latency value Ваторопин Андрей
2025-02-07 2:52 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedbefb8-7979-4482-a2af-e12eda4a4b6f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.vatoropin@crpt.ru \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox