Hi Luiz,

On Mon, Jul 20, 2026 at 11:12:49PM -0300, Luiz Angelo Daros de Luca wrote:
> Initially, I modeled the driver purely as a cooling device. However,
> following Sashiko-dev's suggestion in a previous review, I converted
> it to expose PWM channels so it could be used with the generic pwm-fan
> driver (which indeed makes the code cleaner). My primary experience is
> with DSA switches, so hwmon is a new area for me.

I like the driver exposing a generic PWM. For me it's quite in line with
the "Linux spirit" to do things with devices that are possible even if
that doesn't figure in the vendor's scheme.

> Whatever you and the DT maintainers agree on, I will gladly adjust for v3.

But my opinion doesn't count ... :-)

Best regards
Uwe