From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50BA73B42F6 for ; Thu, 23 Jul 2026 06:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788089; cv=none; b=AYCtLBd4dwfT02r8XlI0s6R18zEUSuhFxQjS53bN/f8p7dsBobg7vLhZ3GlJmynjJMjZsMX5Zg9ZBk6mBf6XM0KylDYCXRr6TKwWzX4w2icqCRmErYEPtsA367hcJrTGFLfW7Wejub700U+gx8ST61Vd/wmqSctf39diBS6bSoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788089; c=relaxed/simple; bh=TQAEV7UNUSBt5hCHAIhIYZaRcGmEyjeZFj3OyVcrCeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ULrilIs8QHnYv8VkY900Ooejkvi5QU9/Ch9mv7Cn4w9uuDjWl5jRK8viSqNObLx0f5xBDrEGn/fXYB7hw913jqSntijkewtreWRt7YaSYUqihSuXRVX3U8xnIjVVfFAU1JeL/5b/7+5q70yt7Mq9iyPShJp57F+Zp7Ann0ZM8dU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=e8n4LgNd; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="e8n4LgNd" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f752b3423so132262f8f.3 for ; Wed, 22 Jul 2026 23:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784788085; x=1785392885; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2TD6c2aawyPviSqpm5Nt3rY9T6uJCx1d6aW8Jwv1HfI=; b=e8n4LgNdC8mDUP3yGwpA3WlCKZ3sVXKKgl7G9mOyX0iWUQKXry8iF+ynsURmyyOq4S Y/e05FSvJsWQE0TRHQtzo4s84+9fvoKFiFDc19mHET/KbgGDnMVth4b2XLYBuMFs6KDy Emt7xCYDPjrVHbUhSP7UlvYeuMXLzJs2CnZKkNg7+2zI9RdNCteuLxPSSjZ2PRh1dgV2 2ziHW6Rm+MgeDnHuwE4Nyxwrk8a/TFe6URh6NL/TN/gPBNixDHA0DzrMj1gMIMDSErzF jOu53lVJs+aeG7w90UvOFiNSotx7IgIXckaIAMIuCXQVsRdkbcB668unOmHgWP1XT7cZ p/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784788085; x=1785392885; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2TD6c2aawyPviSqpm5Nt3rY9T6uJCx1d6aW8Jwv1HfI=; b=juXuRe0kNgIwi8mMbj1oNVR1PrtGENFaZXMi5cFXcxwGrdKxJmmE9lXXglSwJwOR1b 9fn9L4164WsK0NBg09++fI84d0DtopvrGH2zlJ0GR64buTmGhwFSPp8HuKAuQvrbMDIG ewYUCObHlQ1I+66bhOHWB7PvFddeCf/bkSuaMvleQIoaHPbnjM/Sg9dd3w9GDab4w1WG EWWjfmAo/L1MzjKeo8V2hZ1/Jbn41eBpM0bmjrKXflbppoNNbdt79ZA8EpJJSldvU3r6 22yNhmpeiSaiUhUViDsSOh2qUtevQ8rz2iZIIjR795EKuKX5uAWDSM81uyW+rntyyn9O 2+bA== X-Forwarded-Encrypted: i=1; AHgh+RpR+UGCn9+t06BNZiHc2GIJog066bLm30nfCrBki/j9PHxmvGlk8dih8Uy0dMAsy2qZ4I1SG/M+sbIbrQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yw0vZ47UeBft0Wxp3tvD7Q63+AOOiBSn4nupzA6B90IGGVk+72J PGSa+yQly9yMM0kERtmo8FrnGVHb+t4VCFsg+Dy4z9uIOm5TzGygviAYkwLF9Bx92MY= X-Gm-Gg: AR+sD13kqQWCN54DO4i+6olzvulAxwUVwhJ8QEQ96Fn4ObH0lRL5txuG90U0VoGtJGK Sdyyya2IjYWLOHpVRfQPazHV13H6VF//yy+71hXcbTOR6HGHxVMkclPOvGtxSX27isTdtUvwb9C UUxB9DNSL4v0c0d5uDKFr777JfiPgp+Be0k3ZBTzYEIowEVOWxQb8u5HYz9AZ0kYVQZV4FhMs7M ZiJqLeMbYrSMSisXj3tfEEfJspUBJGTNUr3cKc39UHvlCScpHJPBcNwYfeLctuPKBpp01shhNy7 jB+q/aX93eaiyNENHqnjyhLBVU8ExKUiob8T9fRyUq58LzdFu5j+HzfQyEdxs0JGssfBq4T+9jN jyTVUeXqlaIMYMPb9mVVgl07g+20eyDy67Z+yzUUaueC1wKfEJtULLQCmaqBF314eSAUXHw2mpr drw1UGz44= X-Received: by 2002:a05:6000:22c7:b0:47f:6fd2:12ff with SMTP id ffacd0b85a97d-47f8da5c9efmr1980906f8f.9.1784788085516; Wed, 22 Jul 2026 23:28:05 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85b9a5c4sm12114701f8f.8.2026.07.22.23.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 23:28:04 -0700 (PDT) Date: Thu, 23 Jul 2026 08:28:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Svyatoslav Ryhel Cc: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] hwmon: (emc1403) Convert to use OF bindings Message-ID: References: <20260721095935.439174-1-clamor95@gmail.com> <20260721095935.439174-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l6sn4pufjezkt2ci" Content-Disposition: inline In-Reply-To: <20260721095935.439174-3-clamor95@gmail.com> --l6sn4pufjezkt2ci Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 2/3] hwmon: (emc1403) Convert to use OF bindings MIME-Version: 1.0 Hello, On Tue, Jul 21, 2026 at 12:59:34PM +0300, Svyatoslav Ryhel wrote: > From: Jonas Schw=F6bel >=20 > Add OF match compatible table to be able to use this driver with Device > Trees. >=20 > Signed-off-by: Jonas Schw=F6bel > Signed-off-by: Svyatoslav Ryhel > Reviewed-by: Guenter Roeck Please put your S-o-b line last. > --- > drivers/hwmon/emc1403.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c > index cd753b38709f2..b7ab6069ec7b1 100644 > --- a/drivers/hwmon/emc1403.c > +++ b/drivers/hwmon/emc1403.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include Don't add please. struct of_device_id is also provided by so adding isn't needed. > #include > #include > #include > [...] > @@ -682,10 +683,21 @@ static const unsigned short emc1403_address_list[] = =3D { > 0x18, 0x1c, 0x29, 0x3c, 0x4c, 0x4d, 0x5c, I2C_CLIENT_END > }; > =20 > +static const struct of_device_id emc1403_of_match[] =3D { > + { .compatible =3D "smsc,emc1402", .data =3D (void *)emc1402 }, > + { .compatible =3D "smsc,emc1403", .data =3D (void *)emc1403 }, > + { .compatible =3D "smsc,emc1404", .data =3D (void *)emc1404 }, > + { .compatible =3D "smsc,emc1428", .data =3D (void *)emc1428 }, > + { } > + Unusual empty line here. > +}; > +MODULE_DEVICE_TABLE(of, emc1403_of_match); > + Best regards Uwe --l6sn4pufjezkt2ci Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmphtHEACgkQj4D7WH0S /k4H9Qf/eIS4Qz8jNjTZB5EcrdJYqD0cdgZY44kCeDGMBB625M8vmpG7qAv2xnqF 0lGgOTpDoCEs+IgmNz8ISciUqEeY7PWmCge3u6jKZteesuUBX1tMrtnR5DPjVNUv jV6gAM1O287rIzQjp59TZ6tcQe670H3YK+tZAZOIOgpCg5C8FNUOanj9B/sGgnn8 lF3XTCng+Kh6FacdHSPIEwi/FURNxIwy0aKXjPsxEse7EcC4fsTnmjHubUsWdtOm r8cBcczstoZwosFPOMzSGgft070Ay2Xq2J18y7uYgjpK22gqxuxI6tXe4fucREy9 YSZUBJ9ebV0SVa8smQjX8NPHHGxKJA== =n8hC -----END PGP SIGNATURE----- --l6sn4pufjezkt2ci--