From: Vincent Jardin <vjardin@free.fr>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 3/3] hwmon: pmbus: add MPQ8646 driver
Date: Fri, 24 Jul 2026 12:12:38 +0200 [thread overview]
Message-ID: <amM6lniioiowPIPx@L30177.local> (raw)
In-Reply-To: <e3b1def9-a077-4247-b306-9c02d8de7c10@roeck-us.net>
Hi Guenter,
> Many if not all of those commands should really not be part of this driver,
> and commands such as probe_page_write would be extremely dangerous and
> mess up the driver if ever used.
>
> Are you really sure you want to expose all those to the user, instead
> of (say) force them to use i2c_dev if they really want to risk turning
> the affected board(s) into a brick ?
your wise comment is welcomed. You are right, when I check the rationals why I did it:
it was related to some bring up issues I needed to debug and I thought first that
it would make sense to keep them in order to avoid loosing it, but the downside/risk
it not a good way to maintain it.
I'll propose a v6 with a removal of a part and with a CONFIG_SENSORS_MPQ8646_DEBUG_UNSAFE
for a reduced subset of those.
Best regards,
Vincent
prev parent reply other threads:[~2026-07-24 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 21:38 [PATCH v4 0/3] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-23 21:38 ` [PATCH v4 1/3] hwmon: pmbus: event notification with alarms Vincent Jardin via B4 Relay
2026-07-23 21:50 ` sashiko-bot
2026-07-23 21:38 ` [PATCH v4 2/3] dt-bindings: hwmon: pmbus: add MPS MPQ8646 binding Vincent Jardin via B4 Relay
2026-07-23 21:45 ` sashiko-bot
2026-07-23 21:38 ` [PATCH v4 3/3] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-23 21:54 ` sashiko-bot
2026-07-23 23:49 ` Guenter Roeck
2026-07-24 10:12 ` Vincent Jardin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amM6lniioiowPIPx@L30177.local \
--to=vjardin@free.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox