Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
	 Nuno Sa <nuno.sa@analog.com>
Subject: Re: [PATCH 0/3] hwmon: (ltc4282) Fix issues reported by Sashiko
Date: Wed, 5 Aug 2026 10:26:54 +0100	[thread overview]
Message-ID: <anMA34nFCvAQUk6V@nsa> (raw)
In-Reply-To: <20260805005721.1566034-1-linux@roeck-us.net>

On Tue, Aug 04, 2026 at 05:57:18PM -0700, Guenter Roeck wrote:
> This series started with a patch fixing a potential overflow issue in
> maximum poer calculations. Sashiko then reported a similar problem when
> setting current limits, and finally found a problem when evaluating
> adi,current-limit-sense-microvolt.
> 
> This series fixes all those problems.
> 
> Note that Sashiko reports more issues in this driver. Leave those
> to be fixed later.
> 
> ----------------------------------------------------------------
> Guenter Roeck (3):
>       hwmon: (ltc4282) Avoid overflow in maximum power calculation
>       hwmon: (ltc4282) Clamp negative current limits
>       hwmon: (ltc4282) Fix parsing adi,current-limit-sense-microvolt
> 
>  drivers/hwmon/ltc4282.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

Hi Guenter,

During ltc4283 sashiko's review was clear to me that this one also needed some
attention but no time for it so far. So thanks for this.

Also, the clk_init_data remark is very much an issue. Not sure if you
can fit that in this series. Or I can also send a quick patch for it.

Regarding the series, just one suggestion from me. With that:

Reviewed-by: Nuno Sá <nuno.sa@analog.com>


  parent reply	other threads:[~2026-08-05  9:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05  0:57 [PATCH 0/3] hwmon: (ltc4282) Fix issues reported by Sashiko Guenter Roeck
2026-08-05  0:57 ` [PATCH 1/3] hwmon: (ltc4282) Avoid overflow in maximum power calculation Guenter Roeck
2026-08-05  1:07   ` sashiko-bot
2026-08-05  0:57 ` [PATCH 2/3] hwmon: (ltc4282) Clamp negative current limits Guenter Roeck
2026-08-05  1:04   ` sashiko-bot
2026-08-05  9:22   ` Nuno Sá
2026-08-05 15:41     ` Guenter Roeck
2026-08-05 16:14       ` Nuno Sá
2026-08-05 17:19         ` Guenter Roeck
2026-08-05  0:57 ` [PATCH 3/3] hwmon: (ltc4282) Fix parsing adi,current-limit-sense-microvolt Guenter Roeck
2026-08-05  1:08   ` sashiko-bot
2026-08-05  9:26 ` Nuno Sá [this message]
2026-08-05 14:28   ` [PATCH 0/3] hwmon: (ltc4282) Fix issues reported by Sashiko Guenter Roeck
2026-08-05 16:15     ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anMA34nFCvAQUk6V@nsa \
    --to=noname.nuno@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox