From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE3A409273 for ; Mon, 24 Aug 2026 12:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573684; cv=none; b=TJduRNZ5KOd21kjyPsVcxWkK4HbkOtBAf80wA+R+ZLFe2ZOJe0CUm++atCTHnpA/0B97gbhBK6vnspZb8DLDUXJWQIyYqn72wXJ9ZxvGAZCWSbv+BNY6nmoYjXvRIdenFeCsB+5iAoh/yT13+xcm6Ht/BvC9StybKuwrYxdr0ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573684; c=relaxed/simple; bh=eiBo1yduJHaXAj53sijSuIC7kmal8T2Qf0O1edtX+Zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tdtnopMes5/e6RiVkC3APp5jPRyeHcswEC1W/GPMtdnPd1yHqeUhb1x9OEScWFmh59t2xfndZ5yE0y1rTgXxXJ9bAbB+gjr0hFKCycdEn27Q9tPP8MSEwkcLksGzzPcvFVGhH5SFZ7BIWutM0u+TJHxiHd5x+VYPSQg8VqU27Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=ak5bNc39; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="ak5bNc39" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a1542cdb53so4104341a12.2 for ; Mon, 24 Aug 2026 05:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787573679; x=1788178479; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IJ2S2NN5RmqVB8PHkfxAhd8Zl5dVEhVpefrqaDYB2O0=; b=ak5bNc396c9nI3LQikLj+knbykk1XtzUDJ7bNWAGhrX5w0pfWO1C37kPAJRwdUtj1h sslNEKNO3hPYWl3Yb1w8pXlcDevqqR+63cfLaN6ZokSWN0SD+XGGtZgcdYCNFwOJMEWD KNVew/vQPLsMyNHNeCFgy/GebeEhhSusKESZsjs+wE23sAwvrhMMNhONhjI6xgXgrucb M0/PfaLb0QNn7gqGmuf1HomtPB8ek16E6xIjCnhGZaATooZZnf3eUIIH3ClON7Y8F2b+ 7QSmXVMODEK3WeYqOVQKw5SFuxYZhD2cNkK6uewInDHJMil0PEr/XeCJG54jGm7wjX8Q +KDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787573679; x=1788178479; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IJ2S2NN5RmqVB8PHkfxAhd8Zl5dVEhVpefrqaDYB2O0=; b=PVe5FLn5cneZZ5gK7l5Z+zICq0cPTS7bkltcb6kCg2w0fGa1f7XsvjyEaFNInponjL ll38ESu0Hs78lN53n1EIl3foulx1HH6lReQ7m//blDCz99LxNK8E2uvmB8vOy6JcNv16 IlXX8DBvjH0GU0ZNpyf5P+jDXqOU0l4eq4AEP5A7VgwMfHt4bQ9b7vI2xrF6AL2RIW/i 5jVjQ+jazmehrWMYf7nBss3sod2GkwFLDhr3sJ/oghpXmkdfN5ZFuB2AchOUbqmWLkTf mu0F3oWA08oxCFD+uY6+7lj6UckggICrGLIHpGbPbI/RBp2Ulo7+DRMkf6cbOu+an5RH +fFQ== X-Forwarded-Encrypted: i=1; AHgh+RoF9FtOXy5Xa3c0YrSR1XGllsET9XRfFhLv8+6mzw0FmC2PcM5CBwfvP6LAqllTwUQjNEwhp/n1+qSZfQ==@vger.kernel.org X-Gm-Message-State: AFuF++msun/IxjsZA0Zj69OuyjtYXLGm4gUNcXe60X1m50ldGDhh82Gi 8xI9VOE5+L/GE6BzJsDuPEV4cy2pbhsQJtRkpfR+MVJc/qUgT7D47eZIYiGEArn+Utg= X-Gm-Gg: AR+sD10imI/bIfql94P0KHq3vULm/EovvL/+eA7/heUqH6GPnjN903J1y6N2rlQGUic Z9uTXSsphgz2t8IZFj5EYPStwidkFElKC8mUqqe9oNYb9Gd0qr741hrNeYFE42MlJoMGryJbhzS QbJEKhI6zrMZVS0iJVBbdjq7zkfVsE7w9T5bCQ/qAIY6+OtfuKcYaHSkXfa/PUVgmYIOn9MmCdY lX+JvEgcIhXgLfkfaDcT1Pw8Iyuf8WE1Ln4I7N5ffkGblKo3FhprWwxD/vz9+X3j5iGnQB0nFxP qh6wfEcZRvSc0G4y24EkgqAFqrahRG2K8ql/GSb/ZXmNUnGAT6ogXlwuE20t/uzjYluZ9w+DOW7 a8Jd77cc4PoVWXaTimkUat6yZ9axxiDbQb2A9gjQ5V5ebn48NozJmglTofTQ6evs93bsiGNQ0VK oU7apCh1zE15HnRQfS2XqPnHKhknWXxZj6I3bLqVScDDMrOLj+F4f7yXJLY48cbhI9B1a59tUlk 0ePzWx4gH/+8tz+naf9d3BiCQuW8pMBSHsYTpS+W1Fa7ANatBcv X-Received: by 2002:a05:6402:2b98:b0:6a3:6d6d:2296 with SMTP id 4fb4d7f45d1cf-6a582b0cfe9mr21318328a12.5.1787573679054; Mon, 24 Aug 2026 05:14:39 -0700 (PDT) Received: from localhost (p200300f65f19a904efa8a94b704adaa2.dip0.t-ipconnect.de. [2003:f6:5f19:a904:efa8:a94b:704a:daa2]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6a59e00129fsm10155492a12.1.2026.08.24.05.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 05:14:38 -0700 (PDT) Date: Mon, 24 Aug 2026 14:14:37 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Andersson Cc: Sudeep Holla , Cristian Marussi , Nathan Chancellor , Nicolas Schier , Michael Turquette , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Hans de Goede , Stephen Boyd , Brian Masney , "Rafael J. Wysocki" , Viresh Kumar , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Guenter Roeck , Jyoti Bhayana , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Dmitry Torokhov , Ulf Hansson , Liam Girdwood , Mark Brown , Philipp Zabel , Alexandre Belloni , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 1/2] module: add SCMI device table alias support Message-ID: References: <20260618-scmi-modalias-v2-0-8c7547c1be21@oss.qualcomm.com> <20260618-scmi-modalias-v2-1-8c7547c1be21@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2dhawfj2mm2jx7wk" Content-Disposition: inline In-Reply-To: <20260618-scmi-modalias-v2-1-8c7547c1be21@oss.qualcomm.com> --2dhawfj2mm2jx7wk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 1/2] module: add SCMI device table alias support MIME-Version: 1.0 Hello, On Thu, Jun 18, 2026 at 03:56:34PM +0000, Bjorn Andersson wrote: > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_deviceta= ble.h > index 3b0c9a251a2e..769382f2eadd 100644 > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -473,6 +473,17 @@ struct rpmsg_device_id { > kernel_ulong_t driver_data; > }; > =20 > +/* scmi */ > + > +#define SCMI_NAME_SIZE 32 > +#define SCMI_MODULE_PREFIX "scmi:" > + > +struct scmi_device_id { > + __u8 protocol_id; > + char name[SCMI_NAME_SIZE]; > + kernel_ulong_t driver_data; > +}; > + Note this won't apply since commit ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers"). Please create a header below include/device-id for scmi similar to what was done in ad428f5811bd. (And don't add an #include for it to mod_devicetable.h, but to the modpost program only.) Also please only add a driver_data member if you need it. And if you do, consider using union { kernel_ulong_t driver_data; const void *driver_data_ptr; }; instead of a plain kernel_ulong_t driver_data member. I'm working (less than part-time) on changing the existing device-id members accordingly. See e.g. https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.c= om for an extended rationale. Best regards Uwe --2dhawfj2mm2jx7wk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqMNaoACgkQj4D7WH0S /k4jGgf/c9brV06dZI0ixNsgSDxInOAAwxzw0Va6pEilBFWeD/1x8NZxQxIb86eu ERFi9ET7K8J1CkEXpSDumSzKSUdfMylIEURvojgjfnQEsYGjKUB3lgyc6ZMvZJE8 KVGIQQhfXJzgdOen9ivFrmp13avoOEZecODfflOtBiCVBT9yqo9G8cB98iPlfN0n /20yUKuCi9BVxfitySRFAt3h5YGf8mWqJYyRGszONcDeatlQ3hYxcZRc6nWohvA6 Pj79A4QISdBE4jbZiuZ4B7Tqk88TXQ1mLTCo6WZ0jaoWxESWjauNoBJPyj55WW4m FOrbj1Kew7KV7tsLQ07HGfCNIJuI9A== =DfdU -----END PGP SIGNATURE----- --2dhawfj2mm2jx7wk--