Re: [PATCH] hwmon: (k10temp): Add PCI IDs for 1ah/80h

[Mario Limonciello <mario.limonciello@amd.com>]

On 9/11/26 09:24, Guenter Roeck wrote:
> On 9/11/26 06:43, Mario Limonciello wrote:
>> 1ah/80h uses same base as other programs.  It only supports Tctl.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/hwmon/k10temp.c | 1 +
>>   include/linux/pci_ids.h | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>> index 3e7e63edc6a30..b00081deb2e86 100644
>> --- a/drivers/hwmon/k10temp.c
>> +++ b/drivers/hwmon/k10temp.c
>> @@ -582,6 +582,7 @@ static const struct pci_device_id 
>> k10temp_id_table[] = {
>>       { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
>>       { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
>>       { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3) },
>> +    { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3) },
>>       { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
>>       { PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
>>       {}
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 63774ae2bf71d..57a4ad9984798 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -585,6 +585,7 @@
>>   #define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
>>   #define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
>>   #define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
>> +#define PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3 0x1243
> 
> Please define locally in drivers/hwmon/k10temp.c. I can not touch
> this file, and additions for single-use defines are usually rejected
> by the maintainers.

Thanks, I'll respin accordingly.

> 
> Also, it would be nice to list the chip family in the commit message
> and add it to Documentation/hwmon/k10temp.rst. But then I see that
> all chips from family 1ah are missing from there, so maybe that should
> be a separate patch.
> 
> Thanks,
> Guenter
> 

It would need to wait until after product launch too.  I'll set a 
reminder for myself to do this later when I am allowed to.