From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Guenter Roeck <linux@roeck-us.net>,
Hardware Monitoring <linux-hwmon@vger.kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] hwmon: (shtc1) Fix property misspelling
Date: Wed, 5 Jun 2024 14:02:09 +0800 [thread overview]
Message-ID: <b9342b78-2ffa-4ce1-9ffa-bfb125e9d38f@gtsys.com.hk> (raw)
In-Reply-To: <20240530152311.3765049-1-linux@roeck-us.net>
On 30/5/2024 23:23, Guenter Roeck wrote:
> The property name is "sensirion,low-precision", not
> "sensicon,low-precision".
>
> Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> Fixes: be7373b60df5 ("hwmon: shtc1: add support for device tree bindings")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/shtc1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c
> index 1f96e94967ee..439dd3dba5fc 100644
> --- a/drivers/hwmon/shtc1.c
> +++ b/drivers/hwmon/shtc1.c
> @@ -238,7 +238,7 @@ static int shtc1_probe(struct i2c_client *client)
>
> if (np) {
> data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io");
> - data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision");
> + data->setup.high_precision = !of_property_read_bool(np, "sensirion,low-precision");
> } else {
> if (client->dev.platform_data)
> data->setup = *(struct shtc1_platform_data *)dev->platform_data;
Strange how that can happen!
Thank you catch this misspelled property.
Reviewed-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
prev parent reply other threads:[~2024-06-05 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 15:23 [PATCH] hwmon: (shtc1) Fix property misspelling Guenter Roeck
2024-06-05 6:02 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9342b78-2ffa-4ce1-9ffa-bfb125e9d38f@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox