From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92DCAC43334 for ; Wed, 29 Jun 2022 20:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbiF2UCd (ORCPT ); Wed, 29 Jun 2022 16:02:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231441AbiF2UCb (ORCPT ); Wed, 29 Jun 2022 16:02:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29AAD3ED11; Wed, 29 Jun 2022 13:02:31 -0700 (PDT) Received: from [192.168.2.145] (109-252-118-164.nat.spd-mgts.ru [109.252.118.164]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 40BE7660194C; Wed, 29 Jun 2022 21:02:29 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656532949; bh=XZKTlLtT5IwYyJZvyMZi3Fm4hVnGjrmKXiDIiDRogfw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eqG4tpPX332aqBNR+tZzQwfABs4LYwFRTZb620NZoy6ztChHNeK88ZlYDRnpY3rCC t8PGjaWO3qC5XFDWeEdXMqJX4xGSJkBvGMF6dVZr0CmP+3j/fBh6elX+E5Q50fkVoJ dQ79vsb5eiS9SbTNBPwZpqJaALJeHEEPnp8NLcHlGkQ3dfUN7XPJUlRk+biLh0AGws qP6DNiyPwVwaOOKnrZvRZs1IMJpUWvKYPMVtWSt5T+yA08EvEyrXpQSoDtSGwolpCh reTsHexO4xB9PratqDcj5LKPhn4XbAp5FVm97Oiz0oOTHJC+i2fGu+nwv2ogYZlPrE e1nYqT/ioND+Q== Message-ID: Date: Wed, 29 Jun 2022 23:02:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] hwmon: (lm90) Use worker for alarm notifications Content-Language: en-US To: Guenter Roeck , linux-hwmon@vger.kernel.org Cc: Jean Delvare , linux-kernel@vger.kernel.org References: <20220629154210.2389765-1-linux@roeck-us.net> From: Dmitry Osipenko In-Reply-To: <20220629154210.2389765-1-linux@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 6/29/22 18:42, Guenter Roeck wrote: > Reporting alarms using hwmon_notify_event() may result in a callback > from the thermal subsystem. This means that such notifications must > not hold the update lock to avoid a deadlock. To avoid this situation, > use a worker to handle notifications. > > Reported-by: Dmitry Osipenko > Fixes: e182cf579f0f ("hwmon: (lm90) Rework alarm/status handling") > Signed-off-by: Guenter Roeck > --- > Dmitry, > > can you give this patch a try in your system ? It works, thanks! Tested-by: Dmitry Osipenko -- Best regards, Dmitry