From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF57A1E00AE for ; Wed, 4 Sep 2024 17:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725472514; cv=none; b=CQ7Uw6rSwT9v8o66vXYLaISkzQAuTKI4d3dafd2h9B1JCsE/Tg/T2lJ6jyQ9oCFOHrhLp9Y4FfqyfaUIVLu4b3gRTSlH1sws/3eQvT9rmwGg0m17iJzZlOskU1lb/kx9LREDVQxY7qIMPZxoJ1WSCe4Hr+hYIb9SW/H6er5nm9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725472514; c=relaxed/simple; bh=VWzM6EtUmeeVBM+CvbOkVNtoVZCunbQNZn5u3JdbtV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fzK2j38DY3fNHCfly1A5z3LuR5lEacN7UsUM9PjRwK6zGZdTPg38xRhQoKIeABqMRJZy8Nc3tnMi57VkM//DIUzOsotag8Ly14DyZBWMTqJbY717tBV85g7tkCw9SPvK1O6Loya4fwizwvrnVBbZoC90oe/qXSU/qfTckOps2R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YFs/4z4N; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YFs/4z4N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725472511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpULzeoOquLLnjVucbF5xnPEVwj274syMFrmrkoRAMM=; b=YFs/4z4NhjjgWUoXtCaUhLEVQV7WaFYP1Ohh6NATroLdj4/T30H97+n/GB2vnbTJkIJMcL 8ubNIn+Jpgld/pgAPsZlQjD+IMjxkO12ROpqdwU6cJEN93p/siDVv3vN4B4V5M8FboE4mo T3bvFoOiqPz77pW0Swimib5WBNfqe1g= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-XQ35YI_aO_KK3V0yHjoSlg-1; Wed, 04 Sep 2024 13:55:10 -0400 X-MC-Unique: XQ35YI_aO_KK3V0yHjoSlg-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5c24cd1e1bdso2987172a12.2 for ; Wed, 04 Sep 2024 10:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725472509; x=1726077309; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EpULzeoOquLLnjVucbF5xnPEVwj274syMFrmrkoRAMM=; b=pmIC5gCjWT0Yr1uqhg6wVtoZYzFB92tOXFFuSmldkRdQhXtG+Me2mYYCOdEkPtE2aL 8LhMhad/s1h0iPuM2GebHcojhPC2+Nd/hdD/Fl0fqzxiYIWVHOFRqWvPMocdBmhz3YVl jLo9hwXC3TRSRO2qxuBEggJlRCrXb4uyIPlJdALnnt/Vu8lgYwN572G72RjbdHMx4uJ5 8Z5SW6+5IF0hUzsNNWXCVd9TPCusvJTiswJX3ZZ6XDYhiBF+6//7QOsy+G3TLx47bEq8 x6pwlgiIDTKcoPFQf/QIyQ7ItUroCE3XwbIMsD34v3VqsJGVnuv++5WvNhqdt+Khtw1I MpzA== X-Forwarded-Encrypted: i=1; AJvYcCVvxTIjKCDF+BgFeokn7qYH8z+tN3puatI7CNwuTrICq70jc0SkSoSxHI/ujmqTMbZFMKp4hbDdpZPeEw==@vger.kernel.org X-Gm-Message-State: AOJu0Yyh2lfnUyjxThmqX4+DEkSfmhq+UiXGE8afavjN9Ye+icarIuHV CFB8eCZCx7qHioWNSQW+xCUPvUW2409PkP+ssqJ+krqVKSG2TaQyScxDhcVUYLd+arJKyc+dr4r DJhk5IzEtTdda35lgIjpKQQA0GMnpOIH8DYfLnBpdeRlyoX+mnG3ldulENwEC X-Received: by 2002:a17:907:948f:b0:a86:a417:72d2 with SMTP id a640c23a62f3a-a8a1d32689cmr535400166b.35.1725472509350; Wed, 04 Sep 2024 10:55:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2LPU0ING+4KbER6sgAUpEBU4Mq4znqdOnm47Qu/gv2s5OprciWuiK45hfXxAt/jYUlq4jbQ== X-Received: by 2002:a17:907:948f:b0:a86:a417:72d2 with SMTP id a640c23a62f3a-a8a1d32689cmr535397266b.35.1725472508858; Wed, 04 Sep 2024 10:55:08 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623c2b00sm18489466b.162.2024.09.04.10.55.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 10:55:08 -0700 (PDT) Message-ID: Date: Wed, 4 Sep 2024 19:55:07 +0200 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists To: Guenter Roeck , Armin Wolf Cc: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com, luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com, ilpo.jarvinen@linux.intel.com, jdelvare@suse.com, rafael@kernel.org, lenb@kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240901031055.3030-1-W_Armin@gmx.de> <20240901031055.3030-2-W_Armin@gmx.de> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi All, On 9/2/24 4:28 PM, Guenter Roeck wrote: > On Sun, Sep 01, 2024 at 05:10:51AM +0200, Armin Wolf wrote: >> The BIOS can choose to return no event data in response to a >> WMI event, so the ACPI object passed to the WMI notify handler >> can be NULL. >> >> Check for such a situation and ignore the event in such a case. >> >> Fixes: 23902f98f8d4 ("hwmon: add HP WMI Sensors driver") >> Signed-off-by: Armin Wolf >> Reviewed-by: Ilpo Järvinen > > Applied. Thank you. Unfortunately patch 2/5 touches the same part of the file, so I cannot apply the rest of the series without first bringing this patch into platform-drivers-x86/for-next . Guenter, can you provide an immutable branch/tag with this patch on it; or drop this patch that I merge the entire series through platform-drivers-x86/for-next ? Regards, Hans