Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, linux-hwmon@vger.kernel.org
Subject: Re: [hwmon:watchdog-next 21/22] drivers//watchdog/rza_wdt.c:197:14: warning: cast from pointer to integer of different size
Date: Sun, 23 Sep 2018 09:39:42 -0700	[thread overview]
Message-ID: <c48e6440-e2ad-b3d2-00a9-b26ccacfb36d@roeck-us.net> (raw)
In-Reply-To: <201809232330.s8owRsKI%fengguang.wu@intel.com>

Chris,

On 09/23/2018 08:16 AM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
> head:   419c9ad9c6d4f211ee83d49e2ce6a876cbb1800f
> commit: c24a7cc9df8f17f0726daf9efc6aa290972009e9 [21/22] watchdog: rza_wdt: Support longer timeouts
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          git checkout c24a7cc9df8f17f0726daf9efc6aa290972009e9
>          # save the attached .config to linux build tree
>          GCC_VERSION=7.2.0 make.cross ARCH=sparc64
> 
> All warnings (new ones prefixed by >>):
> 
>     drivers//watchdog/rza_wdt.c: In function 'rza_wdt_probe':
>>> drivers//watchdog/rza_wdt.c:197:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>       priv->cks = (unsigned int)of_device_get_match_data(&pdev->dev);
>                   ^
> 
> vim +197 drivers//watchdog/rza_wdt.c
> 
>     166	
>     167	static int rza_wdt_probe(struct platform_device *pdev)
>     168	{
>     169		struct rza_wdt *priv;
>     170		struct resource *res;
>     171		unsigned long rate;
>     172		int ret;
>     173	
>     174		priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
>     175		if (!priv)
>     176			return -ENOMEM;
>     177	
>     178		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>     179		priv->base = devm_ioremap_resource(&pdev->dev, res);
>     180		if (IS_ERR(priv->base))
>     181			return PTR_ERR(priv->base);
>     182	
>     183		priv->clk = devm_clk_get(&pdev->dev, NULL);
>     184		if (IS_ERR(priv->clk))
>     185			return PTR_ERR(priv->clk);
>     186	
>     187		rate = clk_get_rate(priv->clk);
>     188		if (rate < 16384) {
>     189			dev_err(&pdev->dev, "invalid clock rate (%ld)\n", rate);
>     190			return -ENOENT;
>     191		}
>     192	
>     193		priv->wdev.info = &rza_wdt_ident,
>     194		priv->wdev.ops = &rza_wdt_ops,
>     195		priv->wdev.parent = &pdev->dev;
>     196	
>   > 197		priv->cks = (unsigned int)of_device_get_match_data(&pdev->dev);

Please resubmit with this fixed. Something like
			priv->cks = (unsigned int)(uintptr_t)of_device_get_match_data(&pdev->dev);
should do it.

Thanks,
Guenter

  reply	other threads:[~2018-09-23 22:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 15:16 [hwmon:watchdog-next 21/22] drivers//watchdog/rza_wdt.c:197:14: warning: cast from pointer to integer of different size kbuild test robot
2018-09-23 16:39 ` Guenter Roeck [this message]
2018-09-23 17:49   ` Chris Brandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c48e6440-e2ad-b3d2-00a9-b26ccacfb36d@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=chris.brandt@renesas.com \
    --cc=kbuild-all@01.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox