From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B0EC54EAA for ; Mon, 30 Jan 2023 15:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237760AbjA3PGp (ORCPT ); Mon, 30 Jan 2023 10:06:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237769AbjA3PGn (ORCPT ); Mon, 30 Jan 2023 10:06:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 003081DBA4 for ; Mon, 30 Jan 2023 07:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675091152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yUM0dPONsUdhNpTsUP0aFbzs6vKtU/sYkU05mhf9k4M=; b=FBTHPWYUI9M2pxGGSEDBKN6pCU0yo/dkRXtvBAhzWWKj0tXYk/jk5Mzr7yDYba3GbDPg7h IeRCTaYPf36TIsoZVy/W7CfeyCmd+BUzaa6VD5l/K/W2++VgLKhXJa2e3lYn8YAAK+2Xpz Tf+C7CxVZjsLvBUao5JdvCZhTYERaIs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-14-SV3ahWepM6acbPLTDVcpyA-1; Mon, 30 Jan 2023 10:05:44 -0500 X-MC-Unique: SV3ahWepM6acbPLTDVcpyA-1 Received: by mail-ej1-f69.google.com with SMTP id he34-20020a1709073da200b00887ced84328so2184007ejc.10 for ; Mon, 30 Jan 2023 07:05:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUM0dPONsUdhNpTsUP0aFbzs6vKtU/sYkU05mhf9k4M=; b=ghzRpQ6P20FBjInOPMEM3IpEyfdmlnNtn6S3oGsije915/N7QksrjglXWE7f1yh3zd EKwazB6X2jTpudLpmkhJIMBD9wvNPDltxdOYg8Pbe1faHFrCNdJUj/6OGZ5JsNBo5zqs lYZUMeXyCVcuQpFoFXTUdfpqQxmvz32UMkU9iFGeMMKkoXKOaQUIdid5eUD5joxJynvr za2shKVnhgBQ+ltg/PZ6mgBzWOdyIYJDM9RkR/wGHRvk5DP495nd9n0EHjCdfM8CyXpO 8e8juHHG4nkYKxY/kNiYvuK6s2NmE7O4X6XXJ58sVa4jC59nH/NdLMlFI6dLLJaglpcm tnHQ== X-Gm-Message-State: AFqh2koSa28Esnx9hGGHXgka+Lai27di9xu65w5uvvgKDB4d+C1VWbSv PvItc6PL5ZqERpUcLNqBe5AvnLxjlokWnjjpOs0YGZ7Cwz+8Ae241uPk4kmDXdmoDlwyecFWd9J hb/po+fe5IzcXYwMHnQNwso0= X-Received: by 2002:a05:6402:28cb:b0:49e:db43:1722 with SMTP id ef11-20020a05640228cb00b0049edb431722mr38656373edb.18.1675091143708; Mon, 30 Jan 2023 07:05:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXuQOsjZdhW/i+bNK1dRKHsjjmyb26SL93PMVoyqdZSzL8SNaRBxQ88jkzC8E8k04Wif130wzw== X-Received: by 2002:a05:6402:28cb:b0:49e:db43:1722 with SMTP id ef11-20020a05640228cb00b0049edb431722mr38656350edb.18.1675091143523; Mon, 30 Jan 2023 07:05:43 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id ec2-20020a0564020d4200b004a21d03155bsm4346533edb.88.2023.01.30.07.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 07:05:42 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 16:05:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/5] platform/x86: dell-ddv: Add support for interface version 3 Content-Language: en-US To: Armin Wolf , markgross@kernel.org Cc: jdelvare@suse.com, linux@roeck-us.net, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230126194021.381092-1-W_Armin@gmx.de> <20230126194021.381092-2-W_Armin@gmx.de> From: Hans de Goede In-Reply-To: <20230126194021.381092-2-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi, On 1/26/23 20:40, Armin Wolf wrote: > While trying to solve a bugreport on bugzilla, i learned that > some devices (for example the Dell XPS 17 9710) provide a more > recent DDV WMI interface (version 3). > Since the new interface version just adds an additional method, > no code changes are necessary apart from whitelisting the version. > > Signed-off-by: Armin Wolf Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/dell/dell-wmi-ddv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c > index 2bb449845d14..9cb6ae42dbdc 100644 > --- a/drivers/platform/x86/dell/dell-wmi-ddv.c > +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c > @@ -26,7 +26,8 @@ > > #define DRIVER_NAME "dell-wmi-ddv" > > -#define DELL_DDV_SUPPORTED_INTERFACE 2 > +#define DELL_DDV_SUPPORTED_VERSION_MIN 2 > +#define DELL_DDV_SUPPORTED_VERSION_MAX 3 > #define DELL_DDV_GUID "8A42EA14-4F2A-FD45-6422-0087F7A7E608" > > #define DELL_EPPID_LENGTH 20 > @@ -49,6 +50,7 @@ enum dell_ddv_method { > DELL_DDV_BATTERY_RAW_ANALYTICS_START = 0x0E, > DELL_DDV_BATTERY_RAW_ANALYTICS = 0x0F, > DELL_DDV_BATTERY_DESIGN_VOLTAGE = 0x10, > + DELL_DDV_BATTERY_RAW_ANALYTICS_A_BLOCK = 0x11, /* version 3 */ > > DELL_DDV_INTERFACE_VERSION = 0x12, > > @@ -340,7 +342,7 @@ static int dell_wmi_ddv_probe(struct wmi_device *wdev, const void *context) > return ret; > > dev_dbg(&wdev->dev, "WMI interface version: %d\n", version); > - if (version != DELL_DDV_SUPPORTED_INTERFACE) > + if (version < DELL_DDV_SUPPORTED_VERSION_MIN || version > DELL_DDV_SUPPORTED_VERSION_MAX) > return -ENODEV; > > data = devm_kzalloc(&wdev->dev, sizeof(*data), GFP_KERNEL); > -- > 2.30.2 >