From: Mario Limonciello <mario.limonciello@amd.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
Mario Limonciello <superm1@kernel.org>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (k10temp): Use cpu_feature_enabled() for detecting zen
Date: Wed, 21 Aug 2024 09:34:09 -0500 [thread overview]
Message-ID: <cb08e5d9-17c1-457b-af9a-a172feb5e72f@amd.com> (raw)
In-Reply-To: <20240821130916.GA1062@yaz-khff2.amd.com>
On 8/21/2024 08:09, Yazen Ghannam wrote:
> On Tue, Aug 20, 2024 at 12:35:57AM -0500, Mario Limonciello wrote:
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> This removes some boilerplate from the code and will allow adding
>> future CPUs by just device IDs.
>>
>
> I've been thinking that maybe we stop using PCI IDs entirely.
>
> The PCIe devices that we match on are internal to the SoC. And they're
> not optional. They're basically processor components that are exposed
> through PCI config space for software convenience.
>
> Thoughts?
>
> Thanks,
> Yazen
Yeah I think that's a good idea. The one thing I want to make sure
remains though is that k10temp automatically loads from a CPU modalias.
This is "tangential" to this patch except for the commit message
reference to the PCI IDs.
next prev parent reply other threads:[~2024-08-21 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 5:35 [PATCH] hwmon: (k10temp): Use cpu_feature_enabled() for detecting zen Mario Limonciello
2024-08-21 13:09 ` Yazen Ghannam
2024-08-21 14:34 ` Mario Limonciello [this message]
2024-08-21 23:29 ` Guenter Roeck
2024-08-22 14:19 ` Yazen Ghannam
2024-08-27 3:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb08e5d9-17c1-457b-af9a-a172feb5e72f@amd.com \
--to=mario.limonciello@amd.com \
--cc=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=superm1@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox