From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00F3411A14 for ; Wed, 29 Jul 2026 16:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785342101; cv=none; b=gUcF1MzyBrwQzWIy8my0A+L04lud+yTsrNfXMZB+MqyDbMlz6jqcutLOLSv6dcMsgrUUWitsVSUpXkYx8LIja2cLxNEOWDALyUqYPXfzbvJoZ630qNQuES+MqmsX1M2iIPRJsfLCcD92xsREnjjhMjojRaifKLwlL4h0P80l02s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785342101; c=relaxed/simple; bh=J/dPtV4qOEHFqIZhA5/7ElxHINwksvuDwpgYPO9xLGQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HWjlZlf7P5stiovMRR+jaQC3liZhBMp84D6uIwpNGkHGTOXG/bw7SoqDw5KaN5UD39UiT71vAVxmzYHvJFKleiieyzc5kqxUFZmYsTmNfNUz2EH26cpmweISu4uzRIqbfEXA1nugnMGm+Nl+vQpNvVcjTfOl/932LeNPDYTeHWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XcfE7dqM; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XcfE7dqM" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-ca2fad0ae38so864730a12.3 for ; Wed, 29 Jul 2026 09:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785342099; x=1785946899; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=MGJ04DPjDp5NhuCKplYWqLlAi7JvCa6BgyiKARstS28=; b=XcfE7dqMdujD4xU23tLmnYF/iEGquvd6C7kOqZ8ZqJeBH+em6QJFl76tOfbTURUxot YJ7RWusRIWNMaYruaQj7o3awqwoN48Aj1cNIlZHZzZfVcf5TRYpM/edc1tBBZYedv37R hVPUdC87WujRa9u8ijqycZ8+ocm3MW9Ve9d3qMkbF+dOcJCfKOqVsM6dlPQBLXAJ0bTD 9DuMRFSSh+guIDXpcJnW6NfTAqpyrsqEFG8+O8WVJX+SaLviADMLBhsiFT+uB16C9vbl I6HIniMJslX/exz3U90NLGNI++T8dz2PW/AwrCDx/z1fQZVdarosRAMv+nFrYfnUHobj r5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785342099; x=1785946899; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MGJ04DPjDp5NhuCKplYWqLlAi7JvCa6BgyiKARstS28=; b=Rkbu7ad9/yeY3DS6Bfqdj4kkuX80vdHqa9B5DhIvsHcTBKMaV4eRkwboji7KlYDcI2 1osxYbTzWds6XvCR8hOMW/upib+NXlissyMkBy2KrmyKCsrPwqmq8XUzA5l2+zXZy4sV F4D9v4D2A8scRDGaeNKsWgMaw/2c+ZQbWgV4e1EHX8ACJD5/yjg5rrgk4sa4v9nAXlEO SR6HxEzwZfazPkKYGExI4MX94fajPpz1q47abmgec6qzUhvWMZeKezTX+CESsAoLGnXo WkxBaIH/9aqZtaY3rtwUDwIqKQODOJ84VFSL6NRY6GsP6xqR8/RtYndHw0a8vsQN50NI g/3w== X-Forwarded-Encrypted: i=1; AHgh+Ro2UfESOwuYs45Zd2+8hE1amKgRHVRl4xZ/9EreRxhfzWz5HvN3scwFdrTaUhHIV4v0rBhaRSa9OZZ65g==@vger.kernel.org X-Gm-Message-State: AOJu0YwqM7hlokJcxkYv1r3KJj4e7f1n+P5PdNdeXcIhocsOHxPeVVWE z/zy9K84dQFtPmIA7KuagVOYwxm9VBQ6e8rfyNjWhVpj6xPjYBuwhI4F X-Gm-Gg: AR+sD107defoQpKXy80qCzNtadF+NytPvgiDcPBNlykI4MT41SB1oOYwS1OuXejrCds ccNOJlM99nv+44vABqrKK8MtTua3D7yB40OgzEvPYc4KR4+S5ARnKmAxTU3OHRJqp8ZVoFw/AGK 0XM17qNx2vuCHdJdFT8gy2SZjPNrSxhcou/IzSRAXbEuPtqbQSXyQ2mi9eU+PEd9wVhpevTqVxu mm4mCnR1sPIamQvP/5o6UoF7wlKlP6vzA9Sb39Yj73MkeB9uJxX3t3xKPKXaFapv5dgImGMe/U3 /I7leTDVT8oh49GjWftF7EvysdgDThOxiwXaVpL7JLjOd5a549kxwvfPx6VaV8ceO+AVWF1Xv/c OHs9p6Tcmnk5G+wu8Jglg7UK6Bef3FpPN4L/122LbhmL1H3Hq1BkxRyQKN7s8fCDahA25+QFdgO thnF5hunFEUboriZld9oVtcI//O3PUX0XjwuaS2nClmrRNqU4AeZdjp7jUPA6pBA3yp++stOx4e Q== X-Received: by 2002:a05:6a21:7a82:b0:3c3:994f:b4f5 with SMTP id adf61e73a8af0-3c8ab0db549mr8766339637.28.1785342098975; Wed, 29 Jul 2026 09:21:38 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504db2c4csm11392516eec.28.2026.07.29.09.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 09:21:38 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 29 Jul 2026 09:21:37 -0700 From: Guenter Roeck To: Hongyan Xu Cc: Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , openbmc@lists.ozlabs.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, jianhao.xu@seu.edu.cn Subject: Re: [PATCH v2] hwmon: (npcm750-pwm-fan): stop fan timer on device detach Message-ID: References: <20260729100116.790-1-getshell@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729100116.790-1-getshell@seu.edu.cn> On Wed, Jul 29, 2026 at 06:01:16PM +0800, Hongyan Xu wrote: > When a fan tach channel is present, npcm7xx_pwm_fan_probe() starts > fan_timer. The timer callback polls tach state and rearms the timer, but > the driver has no remove callback or devm cleanup action to stop it. On > device detach, the devm-managed driver data and I/O mappings can be > released while the timer is still pending or running. > > Register a devm cleanup action before starting the timer and shut the > timer down synchronously from that action. > > This issue was found by a static analysis tool. > > Fixes: f1fd4a4db777 ("hwmon: Add NPCM7xx PWM and Fan driver") > Cc: stable@vger.kernel.org > Signed-off-by: Hongyan Xu Applied. Thanks, Guenter