Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-kernel@vger.kernel.org,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"René Rebe" <rene@exactcode.de>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Armin Wolf" <W_Armin@gmx.de>,
	"Stephen Horvath" <s.horvath@outlook.com.au>,
	"Sasha Kozachuk" <skozachuk@google.com>,
	"John Hamrick" <johnham@google.com>,
	"Chris Sarra" <chrissarra@google.com>,
	linux-hwmon@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>
Subject: Re: [RFT PATCH v2 2/3] hwmon: (spd5118) Use spd5118 specific read/write operations
Date: Tue, 18 Jun 2024 15:37:46 -0700	[thread overview]
Message-ID: <d6999770-c308-4ff1-b667-6095c83c55dc@roeck-us.net> (raw)
In-Reply-To: <9440d6f5-3164-40c9-95a1-00403b7f753e@molgen.mpg.de>

Hi Paul,

On 6/18/24 14:45, Paul Menzel wrote:
> Dear Guenter,
> 
> 
> Am 18.06.24 um 23:08 schrieb Guenter Roeck:
> 
>> On 6/18/24 13:37, Paul Menzel wrote:
>> [ ... ]
>>> Unfortunately, it still fails:
>>>
>>>      $ git log --no-decorate --oneline -4
>>>      7ddcff2d44ae3 hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers
>>>      e89136743324f hwmon: (spd5118) Use spd5118 specific read/write operations
>>>      0fcc7279f0cc4 hwmon: (spd5118) Use regmap to implement paging
>>>      801b6aad6fa7a hwmon: (spd5118) Add configuration option for auto-detection
>>>
>>>      $ uname -r
>>>      6.10.0-rc4.mx64.461-00050-g7ddcff2d44ae
>>>      $ sudo bash -c 'echo 56000 > /sys/class/hwmon/hwmon3/temp1_max'
>>>      bash: line 1: echo: write error: No such device or address
>>
>> Now I am really baffled. I don't think we could do anything simpler
>> than that.
>>
>> Please try
>>      sudo i2cset -y -f 0 0x50 0x21 0x06
>>
>> That should update the critical temperature from 85 degrees C
>> to 86 degrees C. If that doesn't work, we'll be really out of luck
>> with that controller (or at least I don't have an idea what else to try).
> 
> Bad news:
> 
>      $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cset -y -f 0 0x50 0x21 0x06
>      Error: Write failed
> 

I wonder if there is some write protect active in your system. I don't see anything
in the spd5118 specification, though, or in the i801 datasheet. I really don't know
what else we could try, sorry. Unfortunately I don't have a system with Intel CPU,
much less one with DDR5, so I won't be able to play with this myself and/or
determine if there is something special with your system, or if this is a generic
problem with i801 controllers.

Let's hope that we get some feedback from others.

Thanks,
Guenter


  reply	other threads:[~2024-06-18 22:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 19:53 [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements Guenter Roeck
2024-06-18 19:53 ` [RFT PATCH v2 1/3] hwmon: (spd5118) Use regmap to implement paging Guenter Roeck
2024-06-18 19:53 ` [RFT PATCH v2 2/3] hwmon: (spd5118) Use spd5118 specific read/write operations Guenter Roeck
2024-06-18 20:37   ` Paul Menzel
2024-06-18 21:08     ` Guenter Roeck
2024-06-18 21:45       ` Paul Menzel
2024-06-18 22:37         ` Guenter Roeck [this message]
2024-06-18 22:59           ` Paul Menzel
2024-06-18 22:28       ` Wolfram Sang
2024-06-18 23:28         ` Armin Wolf
2024-06-18 23:39           ` Paul Menzel
2024-06-19  0:23             ` Guenter Roeck
2024-06-19  0:50               ` Thomas Weißschuh
2024-06-19  1:02                 ` Guenter Roeck
2024-06-19  9:13                   ` Thomas Weißschuh
2024-06-19 14:18                     ` Guenter Roeck
2024-06-18 19:53 ` [RFT PATCH v2 3/3] hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers Guenter Roeck
2024-06-18 20:59 ` [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6999770-c308-4ff1-b667-6095c83c55dc@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=chrissarra@google.com \
    --cc=jdelvare@suse.com \
    --cc=johnham@google.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=pmenzel@molgen.mpg.de \
    --cc=rene@exactcode.de \
    --cc=s.horvath@outlook.com.au \
    --cc=skozachuk@google.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox