From: Guenter Roeck <linux@roeck-us.net>
To: Rosen Penev <rosenp@gmail.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (dell-smm) Reject out-of-range pwm values
Date: Tue, 17 Nov 2026 20:21:44 -0800 [thread overview]
Message-ID: <d6a2831e-ca72-4dfa-bc4e-0470a67232f0@roeck-us.net> (raw)
In-Reply-To: <20261118040417.19049-1-rosenp@gmail.com>
On Tue, Nov 17, 2026 at 08:04:17PM -0800, Rosen Penev wrote:
> dell_smm_write() scales the value written to pwmN with
>
> DIV_ROUND_CLOSEST(val, data->i8k_pwm_mult)
>
> before clamping the result to the valid fan states. The rounding adds
> i8k_pwm_mult / 2 to val first, which overflows for values near
> LONG_MAX and wraps to a large negative number. That is then clamped to
> 0, so writing a huge value turns the fan off instead of running it at
> the highest speed. With the default fan_max of 2, writing any value
> from LONG_MAX - 63 up to LONG_MAX selects fan state 0.
>
> The pwm range is well defined, so return -EINVAL for values outside
> 0 to 255, as is the convention for pwm attributes.
>
> Fixes: e7f5f275c62a ("i8k: Implement hwmon based fan speed control")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-18 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 4:04 [PATCH v2] hwmon: (dell-smm) Reject out-of-range pwm values Rosen Penev
2026-11-18 4:08 ` sashiko-bot
2026-11-18 4:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a2831e-ca72-4dfa-bc4e-0470a67232f0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=pali@kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox