From: Guenter Roeck <linux@roeck-us.net>
To: Nicolin Chen <nicoleotsuka@gmail.com>,
jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com
Cc: afd@ti.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add ina3221 documentation
Date: Thu, 20 Sep 2018 17:45:07 -0700 [thread overview]
Message-ID: <d744da89-ebd3-6059-31bf-e65e4c3d2ea4@roeck-us.net> (raw)
In-Reply-To: <20180921000753.21846-2-nicoleotsuka@gmail.com>
On 09/20/2018 05:07 PM, Nicolin Chen wrote:
> Texas Instruments INA3221 is a triple-channel shunt and bus
> voltage monitor. This patch adds a DT binding doc for it.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> .../devicetree/bindings/hwmon/ina3221.txt | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ina3221.txt b/Documentation/devicetree/bindings/hwmon/ina3221.txt
> new file mode 100644
> index 000000000000..266c9586c9b1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ina3221.txt
> @@ -0,0 +1,23 @@
> +ina3221 properties
> +
> +Required properties:
> +- compatible: Must be "ti,ina3221"
> +- reg: I2C address
> +
> +Optional properties:
> +
> +- ti,channel1-name:
> +- ti,channel2-name:
> +- ti,channel3-name:
> + The names of the input sources (described in the schematics)
> + Set the names with "NC" to indicate not-connected channels
> +
I don't really think this is a good idea - first to specify sensor
names this way, and much less specifying that "NC" means that a sensor
shall be disconnected/disabled.
Also, if we define devicetree support for this chip, it should include
all configuration options required to configure it. This should at
the very least include shunt resistor values.
Thanks,
Guenter
> +Example:
> +
> +ina3221@40 {
> + compatible = "ti,ina3221";
> + reg = <0x40>;
> + ti,channel1-name = "NC";
> + ti,channel2-name = "VDD_5V0_EXT";
> + ti,channel3-name = "VDD_19V";
> +};
>
next prev parent reply other threads:[~2018-09-21 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 0:07 [PATCH 0/2] Add an initial DT binding doc for ina3221 Nicolin Chen
2018-09-21 0:07 ` [PATCH 1/2] dt-bindings: hwmon: Add ina3221 documentation Nicolin Chen
2018-09-21 0:45 ` Guenter Roeck [this message]
2018-09-21 1:24 ` Nicolin Chen
2018-09-21 0:07 ` [PATCH 2/2] hwmon: ina3221: Get channel names from DT node Nicolin Chen
2018-09-21 0:41 ` Guenter Roeck
2018-09-21 1:20 ` Nicolin Chen
2018-09-21 9:18 ` Nicolin Chen
2018-09-21 12:56 ` Guenter Roeck
2018-09-21 17:43 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d744da89-ebd3-6059-31bf-e65e4c3d2ea4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox