From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09301C25B50 for ; Tue, 24 Jan 2023 12:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232664AbjAXMFc (ORCPT ); Tue, 24 Jan 2023 07:05:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232618AbjAXMFb (ORCPT ); Tue, 24 Jan 2023 07:05:31 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8D223847 for ; Tue, 24 Jan 2023 04:05:29 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id j17so11293341wms.0 for ; Tue, 24 Jan 2023 04:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ic8eN3I6cwzBtdtpBaU56bD/9LZvawdWvPnRT+wjLI4=; b=rWmlzRYnGQGrT/p1+Upzo6brYfnNA3TV77vb/6F5OKaWkJ9j5epg1eVnH4Kj50zAtO 4fDeGuV7JGcek1cUKifShvKVNs7w/xq9Xc3Z1pVuOYq1tUhh3u8pGTghoeL/4mbMFrrz Jy2rWieEKKFGi4dPfDI26D0gaQA+sKz3HJdN4bWvBpTDzfsuMCa/li9GSxAYIC8b8qZm ZWp6io6b5QR6pJM5S2uNlOaXqTD+nyfRP16m+ffoWGn9Nuo0xJEvGra6J/rEnVFcquFo G++tDTnkY1aQ1Byzy1cfPsCBtC4M7haq2GX2FH2G5woiU8jzS0voGKXKd9b1G6lnc68a 6bqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ic8eN3I6cwzBtdtpBaU56bD/9LZvawdWvPnRT+wjLI4=; b=k813nD5J5WoxH1hPbOAi14cspqO70rLhrKYWfvI14WTyhMuLDMVznhtMWBuj1ZPHBX 2y1MVt7jqAwArBsfWJHpQQIIXa4pBEtTXpjZMCDu+GCVFAWaUuMPNnPHIhjqCxv2Y51b 07+N7Dmb1XOaZWs3zeO/rITFcZYsOqCgR8DhCYlwvZReUw8xvFLwo8i3GBeUuCRx+prT jVBqUvvTUS/RWSrqsulPtzAshnH03IlYZVLM0Xv8sigkaOVp6KR3slNGzVxCdStx5NLa L+DvoHkbphn8pXXrsOR+obj6kPElht2IRZdNxwmGcHpZomWnYDb8z15ka9u0k7qi0wL2 6tgw== X-Gm-Message-State: AFqh2koCj7k7QupjAp8MWJF76OheDRPT7W/htlnDr1B5KM9n4AoSJvQ0 n8c1hyrI/t/lGp+zNzh1XbVAzPCGMHwtYVxb X-Google-Smtp-Source: AMrXdXtDWLE9/Mow9jmUwl0uKzwwn4gUuscIRtfACEWMupiXSbKnJKzbMHEgbV+4SIedSnZ3LK2PeQ== X-Received: by 2002:a05:600c:21c4:b0:3da:fcf1:d4cc with SMTP id x4-20020a05600c21c400b003dafcf1d4ccmr27434734wmj.30.1674561928413; Tue, 24 Jan 2023 04:05:28 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id w8-20020a05600c2a0800b003d995a704fdsm1749926wme.33.2023.01.24.04.05.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 04:05:28 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 13:05:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator Content-Language: en-US To: Naresh Solanki , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Jean Delvare Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230124110111.3965317-1-Naresh.Solanki@9elements.com> <05947e9f-0667-4565-b481-ca5635da4174@9elements.com> From: Krzysztof Kozlowski In-Reply-To: <05947e9f-0667-4565-b481-ca5635da4174@9elements.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 24/01/2023 12:45, Naresh Solanki wrote: > Hi > > On 24-01-2023 04:40 pm, Krzysztof Kozlowski wrote: >> On 24/01/2023 12:01, Naresh Solanki wrote: >>> From: Patrick Rudolph >>> >>> Add the pmbus driver for the Infineon TDA38640 voltage regulator. >>> >>> Signed-off-by: Patrick Rudolph >>> Signed-off-by: Naresh Solanki >>> --- >>> .../devicetree/bindings/trivial-devices.yaml | 2 + >> >> Split bindings from driver code. > Sure >> >>> drivers/hwmon/pmbus/Kconfig | 16 ++++ >>> drivers/hwmon/pmbus/Makefile | 1 + >>> drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ >>> 4 files changed, 97 insertions(+) >>> create mode 100644 drivers/hwmon/pmbus/tda38640.c >>> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >>> index f5c0a6283e61..a28b02036489 100644 >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >>> @@ -141,6 +141,8 @@ properties: >>> - infineon,slb9645tt >>> # Infineon SLB9673 I2C TPM 2.0 >>> - infineon,slb9673 >>> + # Infineon TDA38640 Voltage Regulator >>> + - infineon,tda38640 >>> # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor >>> - infineon,tlv493d-a1b6 >>> # Infineon Multi-phase Digital VR Controller xdpe11280 >>> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig >>> index 30448e049486..9f4bbb9c487a 100644 >>> --- a/drivers/hwmon/pmbus/Kconfig >>> +++ b/drivers/hwmon/pmbus/Kconfig >>> @@ -395,6 +395,22 @@ config SENSORS_STPDDC60 >>> This driver can also be built as a module. If so, the module will >>> be called stpddc60. >>> >>> +config SENSORS_TDA38640 >>> + tristate "Infineon TDA38640" >>> + help >>> + If you say yes here you get hardware monitoring support for Infineon >>> + TDA38640. >>> + >>> + This driver can also be built as a module. If so, the module will >>> + be called tda38640. >>> + >>> +config SENSORS_TDA38640_REGULATOR >>> + bool "Regulator support for TDA38640 and compatibles" >>> + depends on SENSORS_TDA38640 && REGULATOR >>> + help >>> + If you say yes here you get regulator support for Infineon >>> + TDA38640 as regulator. >> >> Drop entire option, why is it needed? > You mean regulator option ? > This is how other pmbus regulator devices have provided option. Hmmm... I wonder why this is of any use. >> >>> + >>> config SENSORS_TPS40422 >>> tristate "TI TPS40422" >>> help (...) >> >>> +static const struct of_device_id tda38640_of_match[] = { >>> + { .compatible = "infineon,tda38640"}, >>> + { }, >>> +}; >>> +MODULE_DEVICE_TABLE(of, tda38640_of_match); >> >> Where is it used? You miss the user. > I'm not sure if I get your question right. > This chip is used in sbp1 board to power CPU rails. No, where is the data structure used (except module autoloading)? Best regards, Krzysztof