From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DA7C25B0E for ; Fri, 19 Aug 2022 07:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346644AbiHSH61 (ORCPT ); Fri, 19 Aug 2022 03:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345812AbiHSH60 (ORCPT ); Fri, 19 Aug 2022 03:58:26 -0400 Received: from smtp-fw-80006.amazon.com (smtp-fw-80006.amazon.com [99.78.197.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E6DF2409D; Fri, 19 Aug 2022 00:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660895904; x=1692431904; h=message-id:date:mime-version:to:cc:references:from: in-reply-to:content-transfer-encoding:subject; bh=M06Oj1qkv6JJea718PatCeXEmzeDxi4tt2ied10MpBY=; b=qwQgry7cJUftHQNrDsKe8Rzf3kzLDH4tJ1QYqlyiBEOeXt9uWXuXRRRX 2vv1VmNcZhWjmFXpWyRaeGPIdHCmBDljrE2kmneZw1WxSSA2VoC6uIQBV fmJnEgR/+310Eesh7L0yrI4QnqRG+JTFuqhruszVU+pGjrjbrXE/55rju 4=; X-IronPort-AV: E=Sophos;i="5.93,247,1654560000"; d="scan'208";a="120932219" Subject: Re: [PATCH v2 14/16] hwmon: (mr75203) parse thermal coefficients from device-tree Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1d-54a073b7.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2022 07:58:08 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-54a073b7.us-east-1.amazon.com (Postfix) with ESMTPS id E1B891A00B4; Fri, 19 Aug 2022 07:58:05 +0000 (UTC) Received: from EX19D013UWA003.ant.amazon.com (10.13.138.202) by EX13MTAUWA001.ant.amazon.com (10.43.160.118) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 19 Aug 2022 07:58:05 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX19D013UWA003.ant.amazon.com (10.13.138.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.12; Fri, 19 Aug 2022 07:58:04 +0000 Received: from [192.168.95.21] (10.85.143.173) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Fri, 19 Aug 2022 07:57:59 +0000 Message-ID: Date: Fri, 19 Aug 2022 10:57:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Content-Language: en-US To: Guenter Roeck CC: , , , , , , , , , , , , , , , , , , "Farber, Eliav" References: <20220817054321.6519-1-farbere@amazon.com> <20220817054321.6519-15-farbere@amazon.com> <20220818202839.GA3431511@roeck-us.net> From: "Farber, Eliav" In-Reply-To: <20220818202839.GA3431511@roeck-us.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 8/18/2022 11:28 PM, Guenter Roeck wrote: > The calculation was just changed to use new defaults in a previous > patch. This patch makes it quite clear that the coefficients > are implementation (?) dependent. So the previous patch just changes > the defaults to (presumably) the coefficients used in your system. > That is inappropriate. Adding non-default corefficients is ok > and makes sense is supported by the chip, but changing defaults > isn't. The calculation was changed in previous patch to match series 5 of the Moortec Embedded Temperature Sensor (METS) datasheet. In our SOC we use series 6 which has a slightly different equation and different coefficients. I did the changes in steps. With this last change, both series 5 and 6 are supported, in addition to calibrated vs. non-calibrated modes. In addition the data sheet just recommends default values but they also specifically mention that actual values might vary from product to product. -- Regards, Eliav