Re: [PATCH] hwmon: (nct6775) Add support for NCT5525

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/11/2026 14:29, Anton Lundin wrote:
> Extend nct6775 driver to support NCT5525.
> 
> Assisted-by: Copilot:GPT-5.6-Terra

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


> Signed-off-by: Anton Lundin <glance@ac2.se>
> ---
>  .../bindings/hwmon/nuvoton,nct6775.yaml       |   1 +

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.


>  Documentation/hwmon/nct6775.rst               |  10 +-
>  drivers/hwmon/nct6775-core.c                  | 130 +++++++++++++++++-
>  drivers/hwmon/nct6775-i2c.c                   |   6 +-
>  drivers/hwmon/nct6775-platform.c              |  12 ++
>  drivers/hwmon/nct6775.h                       |   3 +-
>  6 files changed, 156 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> index 244470282890..16c21f1f46ef 100644
> --- a/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> @@ -25,6 +25,7 @@ properties:
>        - nuvoton,nct6797
>        - nuvoton,nct6798
>        - nuvoton,nct6799
> +      - nuvoton,nct5525

Also, to spare you one review cycle - don't break the order.


Best regards,
Krzysztof