From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko-reviews@lists.linux.dev,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v12 5/6] hwmon: add NXP MC33978/MC34978 driver
Date: Sat, 16 May 2026 10:06:30 +0200 [thread overview]
Message-ID: <e573fb8f-b507-4d54-b990-57f0ea66fec5@kernel.org> (raw)
In-Reply-To: <20260515183847.D8091C2BCB0@smtp.kernel.org>
On 15/05/2026 20:38, sashiko-bot@kernel.org wrote:
>> Add hardware monitoring support for the NXP MC33978/MC34978 Multiple
>> Switch Detection Interface (MSDI).
>>
>> The hardware utilizes a clear-on-read FAULT register, but physical
>> faults remain asserted as long as the underlying condition exists. This
>> asserts a global FAULT_STAT bit on the SPI bus. To handle this without
>> trapping the CPU in an interrupt storm, this driver implements the
>> following architecture:
>> - Requests a rising-edge nested IRQ (IRQF_TRIGGER_RISING) from the MFD
>> core to catch the initial 0 -> 1 transition of the global fault state.
>> - Caches hwmon-specific alarm bits and calculates state edges (XOR) to
>> isolate alarm transitions from system integrity faults.
>> - Implements a 1Hz delayed workqueue that polls the hardware as long as
>> any alarm is active. This compensates for the edge-triggered IRQ by
>> discovering secondary faults that occur without a rising edge, and
>> detecting when the hardware clears.
>>
>> Assisted-by: Gemini:gemini-3.1-pro Sashiko
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> Reviewed-by: Sashiko <sashiko-bot@kernel.org>
NAK, fake tag.
https://lore.kernel.org/linux-devicetree/ad139e54-a7f0-4d09-832c-6b2bf2e93e03@kernel.org/T/#u
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-16 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:05 [PATCH v12 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI Oleksij Rempel
2026-05-15 16:05 ` [PATCH v12 1/6] dt-bindings: pinctrl: add " Oleksij Rempel
2026-05-15 16:05 ` [PATCH v12 2/6] mfd: add NXP MC33978/MC34978 core driver Oleksij Rempel
2026-05-15 16:48 ` sashiko-bot
2026-05-15 16:05 ` [PATCH v12 3/6] pinctrl: core: Make pin group callbacks optional for pin-only drivers Oleksij Rempel
2026-05-15 17:43 ` sashiko-bot
2026-05-16 8:06 ` Krzysztof Kozlowski
2026-05-15 16:05 ` [PATCH v12 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver Oleksij Rempel
2026-05-15 18:07 ` sashiko-bot
2026-05-15 16:05 ` [PATCH v12 5/6] hwmon: add NXP MC33978/MC34978 driver Oleksij Rempel
2026-05-15 18:38 ` sashiko-bot
2026-05-16 8:06 ` Krzysztof Kozlowski [this message]
2026-05-15 16:05 ` [PATCH v12 6/6] mux: add NXP MC33978/MC34978 AMUX driver Oleksij Rempel
2026-05-15 19:07 ` sashiko-bot
2026-05-16 7:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e573fb8f-b507-4d54-b990-57f0ea66fec5@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox