Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Patrick Rudolph <patrick.rudolph@9elements.com>,
	linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay
Date: Wed, 17 Jul 2024 07:42:08 -0700	[thread overview]
Message-ID: <e83aada2-79b2-4272-ab10-4453083193cd@roeck-us.net> (raw)
In-Reply-To: <20240717073000.786228-1-patrick.rudolph@9elements.com>

Patrick,

On 7/17/24 00:29, Patrick Rudolph wrote:
> Some drivers, like the max15301 or zl6100, are intentionally delaying
> SMBus communications, to prevent transmission errors. As this is necessary
> on additional PMBus compatible devices, implement a generic delay mechanism
> in the pmbus core.
> 
> Introduces two delay settings in the pmbus_driver_info struct, one applies
> to every SMBus transaction and the other is for write transaction only.
> Once set by the driver the SMBus traffic, using the generic pmbus access
> helpers, is automatically delayed when necessary.
> 
> The two settings are:
> access_delay:
>    - Unit in microseconds
>    - Stores the accessed timestamp after every SMBus access
>    - Delays when necessary before the next SMBus access
> 
> write_delay:
>    - Unit in microseconds
>    - Stores the written timestamp after a write SMBus access
>    - Delays when necessary before the next SMBus access
> 
> This allows to drop the custom delay code from the drivers and easily
> introduce this feature in additional pmbus drivers.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---

Sigh (sorry, but this isn't your first patch, and you should know).

Change log goes here.

Guenter


  parent reply	other threads:[~2024-07-17 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17  7:29 [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay Patrick Rudolph
2024-07-17  7:29 ` [PATCH v2 2/5] hwmon: pmbus: max15301: Use generic code Patrick Rudolph
2024-07-17  7:29 ` [PATCH v2 3/5] hwmon: pmbus: ucd9000: " Patrick Rudolph
2024-07-17  7:29 ` [PATCH v2 4/5] hwmon: pmbus: zl6100: " Patrick Rudolph
2024-07-17  7:29 ` [PATCH v2 5/5] hwmon: pmbus: pli12096bc: Add write delay Patrick Rudolph
2024-07-17 14:42 ` Guenter Roeck [this message]
2024-09-01 13:43   ` [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay Guenter Roeck
2024-09-02  7:59     ` Patrick Rudolph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e83aada2-79b2-4272-ab10-4453083193cd@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.rudolph@9elements.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox