From: Guenter Roeck <linux@roeck-us.net>
To: wenliang <wenliang202407@163.com>
Cc: jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (ina226) Add support for SY24655
Date: Wed, 6 Nov 2024 07:39:50 -0800 [thread overview]
Message-ID: <e99cb4a5-eb75-4248-b9ac-db16ed3b4f38@roeck-us.net> (raw)
In-Reply-To: <20241106150547.2538-1-wenliang202407@163.com>
On 11/6/24 07:05, wenliang wrote:
> SY24655: Support for current and voltage detection as well as
> power calculation.
>
> Signed-off-by: wenliang <wenliang202407@163.com>
> ---
> @@ -668,6 +731,11 @@ static umode_t ina2xx_is_visible(const void *_data, enum hwmon_sensor_types type
> if (has_alerts)
> return 0444;
> break;
> + case hwmon_power_average:
> + if (has_power_average)
> + return 0444;
> + break;
> + return 0444;
That is quite obviously wrong. Again, I'll fix it up myself
while applying the patch.
Guenter
prev parent reply other threads:[~2024-11-06 15:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <80bfd968-8f12-46b1-9b72-837502ccdb2a@roeck-us.ne>
2024-10-24 8:30 ` [PATCH v3 1/2] hwmon: modified ina2xx to match SY24655 Wenliang
2024-10-24 8:30 ` [PATCH v3 2/2] dt-bindings: " Wenliang
2024-10-24 16:32 ` Conor Dooley
2024-10-24 16:33 ` Conor Dooley
2024-10-24 16:55 ` Guenter Roeck
2024-10-25 7:56 ` Krzysztof Kozlowski
2024-10-24 17:10 ` [PATCH v3 1/2] hwmon: " Guenter Roeck
2024-11-03 16:39 ` [PATCH linux dev-6.11 v3 1/2] hwmon: (ina226) Add support for SY24655 Wenliang
2024-11-03 16:39 ` [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings Wenliang
2024-11-03 16:46 ` Krzysztof Kozlowski
2024-11-03 16:52 ` Krzysztof Kozlowski
2024-11-03 22:39 ` Conor Dooley
2024-11-03 17:37 ` [PATCH linux dev-6.11 v3 1/2] hwmon: (ina226) Add support for SY24655 Guenter Roeck
2024-11-06 15:05 ` [PATCH " wenliang
2024-11-06 15:05 ` [PATCH v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings wenliang
2024-11-06 15:31 ` [PATCH v3 1/2] hwmon: (ina226) Add support for SY24655 Guenter Roeck
2024-11-06 15:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99cb4a5-eb75-4248-b9ac-db16ed3b4f38@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox