Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>, Armin Wolf <W_Armin@gmx.de>
Cc: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com,
	luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com,
	ilpo.jarvinen@linux.intel.com, jdelvare@suse.com,
	rafael@kernel.org, lenb@kernel.org,
	platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists
Date: Wed, 4 Sep 2024 20:42:02 +0200	[thread overview]
Message-ID: <ea8adf37-9fe2-4a15-9666-e164c192bedb@redhat.com> (raw)
In-Reply-To: <6f900fd9-f850-44a3-9409-18889add2cf3@roeck-us.net>

Hi Guenter,

On 9/4/24 8:38 PM, Guenter Roeck wrote:
> On 9/4/24 10:55, Hans de Goede wrote:
>> Hi All,
>>
>> On 9/2/24 4:28 PM, Guenter Roeck wrote:
>>> On Sun, Sep 01, 2024 at 05:10:51AM +0200, Armin Wolf wrote:
>>>> The BIOS can choose to return no event data in response to a
>>>> WMI event, so the ACPI object passed to the WMI notify handler
>>>> can be NULL.
>>>>
>>>> Check for such a situation and ignore the event in such a case.
>>>>
>>>> Fixes: 23902f98f8d4 ("hwmon: add HP WMI Sensors driver")
>>>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>>>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>>>
>>> Applied.
>>
>> Thank you.
>>
>> Unfortunately patch 2/5 touches the same part of the file,
>> so I cannot apply the rest of the series without first
>> bringing this patch into platform-drivers-x86/for-next .
>>
>> Guenter, can you provide an immutable branch/tag with
>> this patch on it; or drop this patch that I merge
>> the entire series through platform-drivers-x86/for-next ?
>>
> 
> Can you wait a couple of days ? Since this is a bug fix, I had
> planned to send a pull request either later today or; with that,
> the patch would be upstream.

Yes I can wait a couple of days, thank you.

Regards,

Hans




  reply	other threads:[~2024-09-04 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  3:10 [PATCH v2 0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers Armin Wolf
2024-09-01  3:10 ` [PATCH v2 1/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists Armin Wolf
2024-09-02 14:09   ` Ilpo Järvinen
2024-09-02 14:28   ` Guenter Roeck
2024-09-04 17:55     ` Hans de Goede
2024-09-04 18:38       ` Guenter Roeck
2024-09-04 18:42         ` Hans de Goede [this message]
2024-09-04 19:40           ` Guenter Roeck
2024-09-01  3:10 ` [PATCH v2 2/5] platform/x86: wmi: Pass event data directly to legacy notify handlers Armin Wolf
2024-09-01  3:10 ` [PATCH v2 3/5] platform/x86: wmi: Remove wmi_get_event_data() Armin Wolf
2024-09-01  3:10 ` [PATCH v2 4/5] platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data() Armin Wolf
2024-09-01  3:10 ` [PATCH v2 5/5] platform/x86: wmi: Call both legacy and WMI driver notify handlers Armin Wolf
2024-09-05 15:31 ` [PATCH v2 0/5] platform/x86: wmi: Pass event data directly to legacy " Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea8adf37-9fe2-4a15-9666-e164c192bedb@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=W_Armin@gmx.de \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=james@equiv.tech \
    --cc=jdelvare@suse.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luke@ljones.dev \
    --cc=matan@svgalib.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox