Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: lschyi@chromium.org
Cc: Benson Leung <bleung@chromium.org>,
	 Guenter Roeck <groeck@chromium.org>,
	Jean Delvare <jdelvare@suse.com>,
	 Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>,
	 chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org,  linux-doc@vger.kernel.org,
	Sung-Chi Li <lschyi@google.com>
Subject: Re: [PATCH 3/3] hwmon: (cros_ec) register fans into thermal framework cooling devices
Date: Tue, 29 Apr 2025 22:45:56 +0200	[thread overview]
Message-ID: <ec2f7e54-0582-475d-af91-42d9be65cd3e@t-8ch.de> (raw)
In-Reply-To: <20250429-cros_ec_fan-v1-3-a8d9e3efbb1a@chromium.org>

On 2025-04-29 16:14:23+0800, Sung-Chi Li via B4 Relay wrote:
> From: Sung-Chi Li <lschyi@chromium.org>
> 
> Register fans connected under EC as thermal cooling devices as well, so
> these fans can then work with the thermal framework.
> 
> During the driver probing phase, we will also try to register each fan
> as a thermal cooling device based on previous probe result (whether the
> there are fans connected on that channel, and whether EC supports fan
> control). The basic get max state, get current state, and set current
> state methods are then implemented as well.

There is also HWMON_C_REGISTER_TZ, however it depends on OF.
But this patch looks very generic, so maybe it makes sense to implement
it in the hwmon core.

> Signed-off-by: Sung-Chi Li <lschyi@chromium.org>
> ---
>  Documentation/hwmon/cros_ec_hwmon.rst |  2 +
>  drivers/hwmon/cros_ec_hwmon.c         | 72 +++++++++++++++++++++++++++++++++++
>  2 files changed, 74 insertions(+)

<snip>

  reply	other threads:[~2025-04-29 20:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29  8:14 [PATCH 0/3] Export fan control and register fans as cooling devices Sung-Chi Li via B4 Relay
2025-04-29  8:14 ` [PATCH 1/3] platform/chrome: update pwm fan control host commands Sung-Chi Li via B4 Relay
2025-04-30  1:28   ` Tzung-Bi Shih
2025-04-29  8:14 ` [PATCH 2/3] hwmon: (cros_ec) add PWM control over fans Sung-Chi Li via B4 Relay
2025-04-29 21:20   ` Thomas Weißschuh
2025-04-30  7:00     ` Sung-Chi Li
2025-04-30 14:48       ` Thomas Weißschuh
2025-05-02  5:31         ` Sung-Chi Li
2025-04-29  8:14 ` [PATCH 3/3] hwmon: (cros_ec) register fans into thermal framework cooling devices Sung-Chi Li via B4 Relay
2025-04-29 20:45   ` Thomas Weißschuh [this message]
2025-04-30  1:51     ` Sung-Chi Li
2025-04-30 14:36       ` Thomas Weißschuh
2025-04-30 15:38         ` Guenter Roeck
2025-05-02  5:35           ` Sung-Chi Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec2f7e54-0582-475d-af91-42d9be65cd3e@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=corbet@lwn.net \
    --cc=groeck@chromium.org \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lschyi@chromium.org \
    --cc=lschyi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox