From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Milton Miller II <miltonm@us.ibm.com>, Pavel Machek <pavel@ucw.cz>
Cc: linux-hwmon@vger.kernel.org, andrew@lunn.ch, jdelvare@suse.com,
arnd@arndb.de, linux-doc@vger.kernel.org, andrew@aj.id.au,
gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux@roeck-us.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs
Date: Fri, 9 Mar 2018 15:47:01 -0800 [thread overview]
Message-ID: <ed44999b-c877-463e-3a20-415faaab31b2@linux.intel.com> (raw)
In-Reply-To: <OF08D8261E.8F72E5DC-ON0025824B.008218BB-0025824B.008218C6@notes.na.collabserv.com>
Hi Milton,
Thanks for sharing your time to review this patch. Please see my answer
inline.
Jae
On 3/9/2018 3:41 PM, Milton Miller II wrote:
> About 03/07/2018 04:12PM in some time zone, Pavel Machek wrote:
>> Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings:
>> Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs
>>
>> Hi!
>>
>>>> Are these SoCs x86-based?
>>>
>>> Yes, these are ARM SoCs. Please see Andrew's answer as well.
>>
>> Understood, thanks.
>>
>>>>> + Read sampling point selection. The whole period of a bit time
>> will be
>>>>> + divided into 16 time frames. This value will determine which
>> time frame
>>>>> + this controller will sample PECI signal for data read back.
>> Usually in
>>>>> + the middle of a bit time is the best.
>>>>
>>>> English? "This value will determine when this controller"?
>>>>
>>>
>>> Could I change it like below?:
>>>
>>> "This value will determine in which time frame this controller
>> samples PECI
>>> signal for data read back"
>>
>> I guess... I'm not native speaker, I guess this could be improved
>> some
>> more.
>>
>
> I agree this wording is still confusing.
>
> The problem is that the key subject, the time of the sampling, is in the descriptive clause "in which time frame".
>
> "This value will determine the time frame in which the controller will sample"
>
> or perhaps phrase it as saving a specific sample from the over-clock, or a phase of the clock.
>
Yes, that looks more better. I'll change the wording as you suggested.
Thanks a lot!
Jae
>> Best regards,
>> Pavel
>>
>> --
>> (english) http://www.livejournal.com/~pavelmachek
>> (cesky, pictures)
>> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>>
>
> milton
> --
> Speaking for myself not IBM.
>
next prev parent reply other threads:[~2018-03-09 23:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 16:15 [PATCH v2 0/8] PECI device driver introduction Jae Hyun Yoo
2018-02-21 16:15 ` [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core Jae Hyun Yoo
2018-02-21 17:04 ` Andrew Lunn
2018-02-21 20:31 ` Jae Hyun Yoo
2018-02-21 21:51 ` Andrew Lunn
2018-02-21 22:03 ` Jae Hyun Yoo
2018-02-21 17:58 ` Greg KH
2018-02-21 20:42 ` Jae Hyun Yoo
2018-02-22 6:54 ` Greg KH
2018-02-22 17:20 ` Jae Hyun Yoo
2018-02-22 7:01 ` kbuild test robot
2018-02-22 7:01 ` [RFC PATCH] drivers/peci: peci_match_id() can be static kbuild test robot
2018-02-22 17:25 ` Jae Hyun Yoo
2018-03-07 3:19 ` [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core Julia Cartwright
2018-03-07 19:03 ` Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs Jae Hyun Yoo
2018-02-21 17:13 ` Andrew Lunn
2018-02-21 20:35 ` Jae Hyun Yoo
2018-03-06 12:40 ` Pavel Machek
2018-03-06 12:54 ` Andrew Lunn
2018-03-06 13:05 ` Pavel Machek
2018-03-06 13:19 ` Arnd Bergmann
2018-03-06 19:05 ` Jae Hyun Yoo
2018-03-07 22:11 ` Pavel Machek
2018-03-09 23:41 ` Milton Miller II
2018-03-09 23:47 ` Jae Hyun Yoo [this message]
2018-02-21 16:16 ` [PATCH v2 3/8] [PATCH 3/8] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 4/8] [PATCH 4/8] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 5/8] [PATCH [5/8] Documentation: dt-bindings: Add a document for PECI hwmon client driver Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: " Jae Hyun Yoo
2018-03-06 20:28 ` Randy Dunlap
2018-03-06 21:08 ` Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic " Jae Hyun Yoo
2018-02-21 18:26 ` Guenter Roeck
2018-02-21 21:24 ` Jae Hyun Yoo
2018-02-21 21:48 ` Guenter Roeck
2018-02-21 23:07 ` Jae Hyun Yoo
2018-02-22 0:37 ` Andrew Lunn
2018-02-22 1:29 ` Jae Hyun Yoo
2018-02-24 0:00 ` Miguel Ojeda
2018-02-24 9:32 ` Jae Hyun Yoo
2018-03-13 9:32 ` Stef van Os
2018-03-13 18:56 ` Jae Hyun Yoo
2018-02-21 16:16 ` [PATCH v2 8/8] [PATCH 8/8] Add a maintainer for the PECI subsystem Jae Hyun Yoo
2018-03-06 12:40 ` [PATCH v2 0/8] PECI device driver introduction Pavel Machek
2018-03-06 19:21 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed44999b-c877-463e-3a20-415faaab31b2@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox