Re: [PATCH v3 1/3] mfd: da9063: Add HWMON dependencies

Lee Jones
2021-08-05T11:40:18Z

On Wed, 07 Jul 2021, Vincent Pelletier wrote:

> From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
>
> Dependencies required for DA9063 HWMON support.
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
>
> Moved temperature offset reading to hwmon driver.
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>

Nit: Please remove the empty lines between tags.

And format like this please:

[vincent: Moved temperature offset reading to hwmon driver]

> ---
> Changes in v3:
> - moved temperature offset reading to hwmon driver
>
> Changes in v2:
> - registers.h changes moved from patch 2
>
> Originally submitted by Steve Twiss in 2014:
> https://marc.info/?l=linux-kernel&m=139560864709852&w=2
>
> include/linux/mfd/da9063/registers.h | 34 ++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)

Once fixed:

Acked-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog