Re: [PATCH v3 2/3] hwmon: da9063: HWMON driver

Vincent Pelletier
2021-07-11T05:22:59Z

Hello,

On Sat, 10 Jul 2021 21:58:33 -0700, Randy Dunlap <rdunlap@infradead.org> wrote:
> > Beyond what you suggested this also gets rid of:
> > - seems reasonable:
> > - linux/delay.h
> > - linux/init.h
> > - linux/slab.h
> > - looks suspicious to me:
> > - linux/err.h, which means the error constants are indirectly
> > imported. Removing it feels brittle.
> > - linux/kernel.h, although to my surprise a lot of c files do not
> > include it.
> >
> > By default I'll drop the former and keep the latter in the
> > next version, please let me know if another combination is preferred.
> >
>
> Hi,
>
> Please use Rule #1 from Documentation/process/submit-checklist.rst:
>
> 1) If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.
>
> so if Enumbers (error numbers) are used, then #include the header file
> for that.

My mail was poorly phrased, sorry.
I meant that I intend to drop the includes from the "seems reasonable"
group, and to keep those from the "looks suspicious" group.

Regards,
--
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1