Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stefan Popa <stefan.popa@analog.com>
Cc: linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	jic23@kernel.org, andy@kernel.org, nuno.sa@analog.com,
	linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, dlechner@baylibre.com,
	ciprian.hegbeli@analog.com, siratul.islam@linux.dev,
	u.kleine-koenig@baylibre.com, joshua.crofts1@gmail.com
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080
Date: Fri, 31 Jul 2026 09:06:36 +0200	[thread overview]
Message-ID: <f0ec8d8e-b7fe-4620-a715-65af36166e05@kernel.org> (raw)
In-Reply-To: <20260731-steadfast-peculiar-bee-33fec4@quoll>

On 31/07/2026 09:04, Krzysztof Kozlowski wrote:
> On Thu, Jul 30, 2026 at 04:17:37PM +0300, Stefan Popa wrote:
>> +  vdd-supply:
>> +    description: Power supply for the device.
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +    description: ALERT output for overcurrent/undervoltage threshold events.
>> +
>> +  shunt-resistor-micro-ohms:
>> +    description:
>> +      Value of the current-sense shunt resistor connected between the IN+ and
>> +      IN- inputs. Used to scale the reported current.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - shunt-resistor-micro-ohms
> 
> Supply is required
> 
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        adc@20 {
>> +            compatible = "adi,max40080";
>> +            reg = <0x20>;
>> +            #io-channel-cells = <1>;
>> +            shunt-resistor-micro-ohms = <100000>;
>> +        };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e087673237636..e1170230c4bb2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -28893,3 +28893,11 @@ S:	Buried alive in reporters
>>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>  F:	*
>>  F:	*/
>> +
>> +MAXIM MAX40080 CURRENT SENSE AMPLIFIER DRIVER
> 
> Honestly, how did it appear at the end? Do you see any other
> commit/patchset adding it there? No, so this should raise questions on
> your side.

And this is quite different than v5 and nothing explains that change in
the changelog.

Use b4 prep to see what you did between revisions.

Best regards,
Krzysztof

  reply	other threads:[~2026-07-31  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 13:17 [PATCH v6 0/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-07-30 13:17 ` [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080 Stefan Popa
2026-07-30 13:25   ` sashiko-bot
2026-07-30 18:42   ` Siratul Islam
2026-07-31  7:04   ` Krzysztof Kozlowski
2026-07-31  7:06     ` Krzysztof Kozlowski [this message]
2026-07-30 13:17 ` [PATCH v6 2/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-07-30 13:29   ` sashiko-bot
2026-07-31  6:00   ` Siratul Islam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0ec8d8e-b7fe-4620-a715-65af36166e05@kernel.org \
    --to=krzk@kernel.org \
    --cc=andy@kernel.org \
    --cc=ciprian.hegbeli@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=siratul.islam@linux.dev \
    --cc=stefan.popa@analog.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox