From: Dave Hansen <dave.hansen@intel.com>
To: David Laight <david.laight.linux@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Guenter Roeck <linux@roeck-us.net>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Iwona Winiarska <iwona.winiarska@intel.com>,
linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org,
Thomas Gleixner <tglx@kernel.org>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org
Subject: Re: [PATCH] peci: Remove dependency on x86 CPU variables
Date: Thu, 19 Feb 2026 06:57:58 -0800 [thread overview]
Message-ID: <f4697d4b-aaf5-45a0-8de7-54beef48eac3@intel.com> (raw)
In-Reply-To: <20260219102057.1da25411@pumpkin>
On 2/19/26 02:20, David Laight wrote:
>> tl;dr: The non-x86 PECI driver #includes an arch/x86 header. This is
>> ostensibly to avoid duplicating CPU model number constants, but the
>> result is complexity and duplicated *code* which is a far worse fate
>> than duplicated constants.
> Is is possible/sensible to add a check in one file that includes both
> headers that the constants match?
>
> That will help pick up any typos.
I don't think it's worth it. Honestly, the _only_ reason to share names
is to avoid doubling the inevitable name bikeshedding that happens every
time we try to name a CPU model.
I honestly don't think it matters if the names diverge otherwise.
prev parent reply other threads:[~2026-02-19 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 17:03 [PATCH] peci: Remove dependency on x86 CPU variables Dave Hansen
2026-02-18 19:26 ` Sohil Mehta
2026-02-18 19:30 ` Dave Hansen
2026-02-18 19:36 ` Sohil Mehta
2026-02-18 19:43 ` Sohil Mehta
2026-02-18 19:46 ` Dave Hansen
2026-02-19 10:20 ` David Laight
2026-02-19 14:57 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4697d4b-aaf5-45a0-8de7-54beef48eac3@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=hpa@zytor.com \
--cc=iwona.winiarska@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox