Re: [PATCH v2 1/2] platform/x86: hp-wmi: add manual fan control for Victus S models

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Mon, 12 Jan 2026, Krishna Chomal wrote:

> On Mon, Jan 12, 2026 at 05:13:05PM +0200, Ilpo Järvinen wrote:
> > On Tue, 30 Dec 2025, Krishna Chomal wrote:
> > 
> [snip]
> > >  #include <linux/string.h>
> > >  #include <linux/dmi.h>
> > > +#include <linux/fixp-arith.h>
> > > +#include <linux/limits.h>
> > > +#include <linux/minmax.h>
> > > +#include <linux/compiler_attributes.h>
> > > 
> [snip]

Hmm, these should be ordered alphabetically and if the existing one 
aren't, try your best (or add a patch to fix the order for all).

> > > +
> > > +struct victus_s_fan_table_header {
> > > +	u8 unknown;
> > > +	u8 num_entries;
> > > +} __packed;
> > 
> > Please add #include for __packed.
> > 
> 
> __packed is defined in compiler_attributes.h, which is included in this
> patch. Please let me know if there are any other headers that should be
> included.

Sorry, I don't know why I didn't notice it (too much reviewing in a row or 
too much multi-tasking I guess :-)).


-- 
 i.