From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Justin Ledford <justinledford@google.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790
Date: Tue, 13 Aug 2024 18:20:09 +0200 [thread overview]
Message-ID: <f9f97553-a50a-44c0-b817-3a44f730cfeb@linaro.org> (raw)
In-Reply-To: <20240813084152.25002-2-chanh@os.amperecomputing.com>
On 13/08/2024 10:41, Chanh Nguyen wrote:
> Add device tree bindings and an example for max31790 device.
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@21 {
> + compatible = "maxim,max31790";
> + reg = <0x21>;
> + clocks = <&sys_clk>;
> + resets = <&reset 0>;
This node is incomplete. I asked to make the example complete, not by
adding two incomplete examples or other ways... The binding description
says this device controls fan. If so, where is the fan here?
IOW, keep only one, complete example.
Rest looks good. With this addressed (and optionally with maintainer
change, which Conor asked):
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-13 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 8:41 [PATCH v3 0/1] Update the max31790 driver Chanh Nguyen
2024-08-13 8:41 ` [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790 Chanh Nguyen
2024-08-13 15:33 ` Conor Dooley
2024-08-13 15:52 ` Guenter Roeck
2024-08-13 16:16 ` Conor Dooley
2024-08-13 16:21 ` Krzysztof Kozlowski
2024-08-14 8:58 ` Chanh Nguyen
2024-08-14 7:31 ` Chanh Nguyen
2024-08-13 16:20 ` Krzysztof Kozlowski [this message]
2024-08-14 8:54 ` Chanh Nguyen
2024-08-13 8:44 ` [PATCH v3 0/1] Update the max31790 driver Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f97553-a50a-44c0-b817-3a44f730cfeb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox