From: Guenter Roeck <linux@roeck-us.net>
To: Marek Vasut <marex@denx.de>
Cc: linux-hwmon@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: (pwm-fan) Introduce start from stopped state handling
Date: Mon, 11 Nov 2024 11:32:52 -0800 [thread overview]
Message-ID: <feaa62fa-cf0b-4e4c-aadc-007729ec7ee6@roeck-us.net> (raw)
In-Reply-To: <20241106185925.223736-2-marex@denx.de>
On Wed, Nov 06, 2024 at 07:59:05PM +0100, Marek Vasut wrote:
> Delta AFC0612DB-F00 fan has to be set to at least 30% PWM duty cycle
> to spin up from a stopped state, and can be afterward throttled down to
> lower PWM duty cycle. Introduce support for operating such fans which
> need to start at higher PWM duty cycle first and can slow down next.
>
> Introduce two new DT properties, "fan-stop-to-start-percent" and
> "fan-stop-to-start-us". The former describes the minimum percent
> of fan RPM at which it will surely spin up from stopped state. This
> value can be found in the fan datasheet and can be converted to PWM
> duty cycle easily. The "fan-stop-to-start-us" describes the minimum
> time in microseconds for which the fan has to be set to stopped state
> start RPM for the fan to surely spin up.
>
> Adjust the PWM setting code such that if the PWM duty cycle is below
> the minimum duty cycle needed by the fan to spin up from stopped state,
> then first set the PWM duty cycle to the minimum duty cycle needed
> by the fan to spin up from stopped state, then wait the time necessary
> for the fan to spin up from stopped state, and finally set the PWM duty
> cycle to the one desired by user.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2024-11-11 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 18:59 [PATCH v3 1/2] dt-bindings: hwmon: pwm-fan: Document start from stopped state properties Marek Vasut
2024-11-06 18:59 ` [PATCH v3 2/2] hwmon: (pwm-fan) Introduce start from stopped state handling Marek Vasut
2024-11-11 19:32 ` Guenter Roeck [this message]
2024-11-07 17:24 ` [PATCH v3 1/2] dt-bindings: hwmon: pwm-fan: Document start from stopped state properties Conor Dooley
2024-11-11 19:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feaa62fa-cf0b-4e4c-aadc-007729ec7ee6@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox