From: Guenter Roeck <linux@roeck-us.net>
To: Ivor Wanders <ivor@iwanders.net>, lkp@intel.com
Cc: W_Armin@gmx.de, linux-hwmon@vger.kernel.org,
luzmaximilian@gmail.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'
Date: Sat, 3 Feb 2024 06:12:09 -0800 [thread overview]
Message-ID: <ffd297c3-4ac7-45e5-bf76-8f4e4e9e603c@roeck-us.net> (raw)
In-Reply-To: <20240203125217.4702-1-ivor@iwanders.net>
On 2/3/24 04:52, Ivor Wanders wrote:
>>>> drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible' [-Wmissing-prototypes]
>> 22 | umode_t surface_fan_hwmon_is_visible(const void *drvdata,
>
> I tried reproducing this, but I think this issue is already fixed in the
> most recent hwmon-next?
> The function should've been marked `static`. It wasn't in the original v5
> patch, but the current commit in the tree (216d66aa89f9fc882) already marks
> the function static, resolving the issue.
>
Yes, I already fixed this up.
Guenter
next prev parent reply other threads:[~2024-02-03 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 4:52 [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible' kernel test robot
2024-02-03 12:52 ` Ivor Wanders
2024-02-03 14:12 ` Guenter Roeck [this message]
2024-02-03 14:16 ` Ivor Wanders
2024-02-03 14:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd297c3-4ac7-45e5-bf76-8f4e4e9e603c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=ivor@iwanders.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luzmaximilian@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).