From: sashiko-bot@kernel.org
To: "Baek Kyu, Kim" <pocj8ur4in@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (sht3x) Return the consumed count for heater writes
Date: Mon, 19 Oct 2026 16:14:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-177848@kernel.org> (raw)
In-Reply-To: <20261019154718.2328055-1-pocj8ur4in@gmail.com>
> heater_enable_store() returns the result of i2c_master_send(), which is
> the two-byte command length on success rather than the sysfs input
> count. This can report more bytes than were supplied, or a partial write
> for a fully processed input. For example, writing "on\n" returns two
> instead of three, so a caller retrying the remaining newline gets
> -EINVAL even though the heater command succeeded. Retrying the remainder
> of "off\n" can also send the heater-off command twice.
>
> Return count after a complete command transfer. Preserve negative I2C
> errors and return -EIO for nonnegative incomplete transfers, so a
> zero-message transfer is not reported as a successful zero-byte write.
> Keep the existing boolean parsing, command selection and locking.
>
> Fixes: 50c22cd154e5 ("hwmon: (sht3x) add humidity heater element control")
> Signed-off-by: Baek Kyu, Kim <pocj8ur4in@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019154718.2328055-1-pocj8ur4in@gmail.com?part=1
next prev parent reply other threads:[~2026-10-19 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 15:47 [PATCH] hwmon: (sht3x) Return the consumed count for heater writes Baek Kyu, Kim
2026-10-19 16:14 ` sashiko-bot [this message]
2026-10-19 20:14 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-177848@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=pocj8ur4in@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox