From: sashiko-bot@kernel.org
To: "Nobuhiro Iwamatsu" <nobuhiro.iwamatsu.x90@mail.toshiba>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 5.10, 5.15, 6.1] hwmon: (drivetemp) Fix driver producing garbage data when SCSI errors occur
Date: Fri, 23 Oct 2026 04:43:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-182292@kernel.org> (raw)
In-Reply-To: <1792730299-21490-1-git-send-email-nobuhiro.iwamatsu.x90@mail.toshiba>
> From: Daniil Stas <daniil.stas@posteo.net>
>
> commit 82163d63ae7a4c36142cd252388737205bb7e4b9 upstream.
>
> scsi_execute_cmd() function can return both negative (linux codes) and
> positive (scsi_cmnd result field) error codes.
>
> Currently the driver just passes error codes of scsi_execute_cmd() to
> hwmon core, which is incorrect because hwmon only checks for negative
> error codes. This leads to hwmon reporting uninitialized data to
> userspace in case of SCSI errors (for example if the disk drive was
> disconnected).
>
> This patch checks scsi_execute_cmd() output and returns -EIO if it's
> error code is positive.
> [ ... ]
> Cc: linux-hwmon@vger.kernel.org
> Link: https://lore.kernel.org/r/20250105213618.531691-1-daniil.stas@posteo.net
> [groeck: Avoid inline variable declaration for portability]
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro.iwamatsu.x90@mail.toshiba>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/1792730299-21490-1-git-send-email-nobuhiro.iwamatsu.x90@mail.toshiba?part=1
next prev parent reply other threads:[~2026-10-23 4:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 4:38 [PATCH 5.10, 5.15, 6.1] hwmon: (drivetemp) Fix driver producing garbage data when SCSI errors occur Nobuhiro Iwamatsu
2026-10-23 4:43 ` sashiko-bot [this message]
2026-10-23 20:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182292@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox