From: sashiko-bot@kernel.org
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays
Date: Tue, 27 Oct 2026 10:53:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-186390@kernel.org> (raw)
In-Reply-To: <ec269df979b1e0a7df04a20eb19505c332679428.1793097104.git.u.kleine-koenig@baylibre.com>
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> auxiliary_device_id that replaces .driver_data by an anonymous union
> (though none of these drivers uses .driver_data, so this patch isn't
> strictly necessary for the plan, but still ok for consistency).
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793097104.git.u.kleine-koenig@baylibre.com?part=13
next prev parent reply other threads:[~2026-10-27 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:53 ` sashiko-bot [this message]
2026-10-27 11:01 ` Sakari Ailus
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-186390@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox