Re: [PATCH 2/2] hwmon: (gigabyte_waterforce) Protect status report data with spinlock

[sashiko-bot@kernel.org]

> waterforce_raw_event() updates temp_input, speed_input, duty_input, and
> the updated timestamp without holding priv->status_report_request_lock
> (and updates priv->updated after complete_all()), while
> waterforce_get_status() and waterforce_read() read those fields without
> synchronization.
> 
> Because HID_CONNECT_HIDRAW is enabled, or when an interrupted wait leaves
> a requested report in flight, waterforce_raw_event() can execute
> concurrently with sysfs reads. Under the Linux kernel memory model this
> constitutes a data race, lacks memory ordering between priv->updated and
> the cached sensor fields on weakly ordered architectures, and allows a
> reader woken by complete_all() to re-enter waterforce_get_status() before
> priv->updated is refreshed.
> 
> Extend priv->status_report_request_lock to cover updating the sensor
> values and priv->updated in waterforce_raw_event(), checking priv->updated
> in waterforce_get_status(), and reading the cached sensor values in
> waterforce_read().
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Fixes: 42ac68e3d4ba ("hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers")
> Cc: Aleksa Savic <savicaleksa83@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031223131.1855967-1-linux@roeck-us.net?part=2