Re: [PATCH v2] hwmon: (it87) Add support for IT8607E

[sashiko-bot@kernel.org]

> The IT8607E is the Super I/O of the Intel NUC6i3SYB and, according to
> Intel's product specification, the NUC6i5SYB (BIOS SYSKLi35.86A). Its
> environment controller is hidden from ACPI (HHMD._STA returns 0), so the
> chip is only reachable through the LPC configuration ports, and the ACPI
> resource check must be bypassed with ignore_resource_conflict=1.
> 
> No datasheet is available. The register layout was compared against the
> IT8603E, and the BIOS fan setup (IT8607PeiInit and FanPei PEI modules of
> SYSKLi35.86A.0071) was disassembled to confirm it programs the same
> "newer autopwm" registers (0x68-0x6d for pwm2). Features are therefore
> copied from the IT8603E.
> 
> Tested on a NUC6i3SYB (BIOS SYSKLi35.86A.0042, chip ID 0x8607, rev 2):
> temperatures agree with coretemp, +3.3V reads 3.31 V, the 3VSB and VBAT
> inputs read plausible values, fan2 tach and pwm2 respond to the
> automatic-curve registers (start 74 C, full speed 92 C, as programmed by
> the BIOS) and to manual mode, and the original values are restored.
> 
> The tachometer was not compared with an external tachometer and the
> voltage scaling was not compared with a multimeter; the values above are
> only cross-checked against coretemp and the expected rail voltages.
> 
> Signed-off-by: Ismael Ojeda Perez <iojedaperez@proton.me>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179357826986.881874.2370184949108951928@proton.me?part=1