Re: [PATCH v2 2/2] hwmon: (pmbus/max20830) Add support for MAX20810, MAX20815, LTM4739, LTM4740

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: (pmbus/max20830) Kconfig help text not updated for new chips
--

commit a48cd701bd54f337809702615b2dcd55ba0b47a3
Author: Carlos Jones Jr <carlosjr.jones@analog.com>

hwmon: (pmbus/max20830) Add support for MAX20810, MAX20815, LTM4739, LTM4740

This commit adds support for the MAX20810, MAX20815, LTM4739, and LTM4740
step-down switching regulators to the max20830 PMBus driver by matching
their IC_DEVICE_ID strings ("MAX20810B" and "MAX20815B") and updating
Documentation/hwmon/max20830.rst.

> diff --git a/drivers/hwmon/pmbus/max20830.c b/drivers/hwmon/pmbus/max20830.c
> index 4d25a084af096..39cce250beca4 100644
> --- a/drivers/hwmon/pmbus/max20830.c
> +++ b/drivers/hwmon/pmbus/max20830.c
> @@ -20,7 +20,15 @@ struct max20830_data {
>  	u32 vout_rfb2;
>  };
>  
> +/*
> + * IC_DEVICE_ID strings matched at probe. The LTM4739/LTM4740 uModules
> + * report their MAX die ID with a "B" suffix, not the "LTM47xx" names in
> + * their datasheets (being corrected); the plain datasheet IDs are not
> + * matched, as no such part has been observed.
> + */
>  static const char * const supported_chip_ids[] = {
> +	"MAX20810B",	/* LTM4739 */
> +	"MAX20815B",	/* LTM4740 */
>  	"MAX20830",
>  	"MAX20830C",
>  	"MAX20840C",

[Severity: Low]
This isn't a bug, but when adding support for MAX20810, MAX20815, LTM4739,
and LTM4740 in supported_chip_ids[] and Documentation/hwmon/max20830.rst,
should the SENSORS_MAX20830 entry in drivers/hwmon/pmbus/Kconfig also be
updated?

Currently drivers/hwmon/pmbus/Kconfig only lists the previously supported
models:

config SENSORS_MAX20830
	tristate "Analog Devices MAX20830 and compatibles"
	help
	  If you say yes here you get hardware monitoring support for Analog
	  Devices MAX20830, MAX20830C, and MAX20840C.

Documentation/hwmon/submitting-patches.rst asks that Kconfig information be
kept up to date when adding functionality to existing drivers, similar to
commit 4cdcd4789fb6 ("hwmon: (max20830) Add support for MAX20830C and
MAX20840C").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103084331.449-1-carlosjr.jones@analog.com?part=2