Re: [PATCH] hwmon: (asus_rog_ryujin) Update cached duty cycle after cooler PWM write

[sashiko-bot@kernel.org]

> In rog_ryujin_write_fixed_duty(), writing a PWM duty cycle to channel 0
> (pump) or channel 1 (internal fan) returns directly from
> rog_ryujin_write_cooler_duty(), skipping the priv->duty_input[channel]
> update at the end of the function. Because the function first fetches
> the pre-write cooler duty via get_cooler_duty_cmd and SET confirmation
> reports do not update priv->duty_input, subsequent sysfs reads within
> the STATUS_VALIDITY (1500 ms) cache window return stale duty values (or,
> on Ryujin III when switching pump source at the reported duty, the
> temporary neighbouring duty written by rog_ryujin_select_pump_source()).
> 
> Furthermore, rog_ryujin_write_fixed_duty() overwrote val in place with
> rog_ryujin_pwm_to_percent(val), so even before the early return was
> introduced, priv->duty_input[channel] stored a 0-100 percentage rather
> than the 0-255 PWM value expected by rog_ryujin_read().
> 
> Keep the 0-100 percentage in a separate local variable and fall through
> on success so priv->duty_input[channel] caches the written 0-255 PWM
> value until the next status refresh.
> 
> Fixes: ed3e03790c5c ("hwmon: Add driver for ASUS ROG RYUJIN II 360 AIO cooler")
> Fixes: b4306c0c8e24 ("hwmon: (asus_rog_ryujin) Rely on subsystem locking")
> Cc: Aleksa Savic <savicaleksa83@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105044843.3262037-1-linux@roeck-us.net?part=1