From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (max31760) Leave standby mode at probe
Date: Sun, 08 Nov 2026 04:03:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-203553@kernel.org> (raw)
In-Reply-To: <20261108-max31760-fixes-v1-2-a61450463059@gmail.com>
> The driver never clears the standby bit (CR2_STBY) during probe.
> While max31760_resume() clears this bit on resume, probe only
> configured CR2_ALERTS.
>
> If the chip was left in standby (for example, by boot firmware or a
> previously running OS before a warm reboot), it remains in standby:
> temperature sensing, fan speed counting, and PWM output are halted.
> This occurs on the Samsung Galaxy XR, where the bootloader places the
> chip in standby during boot.
>
> Clear CR2_STBY alongside setting CR2_ALERTS in probe.
>
> Fixes: 38b04ad02d0d ("drivers: hwmon: Add max31760 fan speed controller driver")
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-max31760-fixes-v1-0-a61450463059@gmail.com?part=2
next prev parent reply other threads:[~2026-11-08 4:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 3:59 [PATCH 0/3] hwmon: (max31760) Fix local limits, standby and the initial fan speed Stanislav Aleksandrov
2026-11-08 3:59 ` [PATCH 1/3] hwmon: (max31760) Fix the local temperature limit registers Stanislav Aleksandrov
2026-11-08 4:03 ` sashiko-bot
2026-11-08 15:53 ` Guenter Roeck
2026-11-08 3:59 ` [PATCH 2/3] hwmon: (max31760) Leave standby mode at probe Stanislav Aleksandrov
2026-11-08 4:03 ` sashiko-bot [this message]
2026-11-08 15:54 ` Guenter Roeck
2026-11-08 3:59 ` [PATCH 3/3] hwmon: (max31760) Report 0 RPM before the first fan speed measurement Stanislav Aleksandrov
2026-11-08 4:03 ` sashiko-bot
2026-11-08 15:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203553@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lightofmysoul@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox