Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pablo Mazzini" <pmazzini@gmail.com>
Cc: linux-hwmon@vger.kernel.org, mfd@lists.linux.dev, lee@kernel.org
Subject: Re: [PATCH v3 3/5] regulator: sy7636a: bind to the I2C device directly
Date: Sun, 08 Nov 2026 09:43:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-203664@kernel.org> (raw)
In-Reply-To: <20261108093602.329554-4-pmazzini@gmail.com>

> Bind the regulator to the chip directly, as the TPS65185 and FP9931
> drivers do, and have it create an auxiliary device for the hwmon driver,
> instead of simple-mfd-i2c creating a cell for each. Drop the MFD glue
> and header. It now probes before the GPIOs may be ready, so report the
> power good GPIO with dev_err_probe(). The hwmon driver then only
> accesses the chip after vin-supply is enabled.
> 
> Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108093602.329554-1-pmazzini@gmail.com?part=3


  reply	other threads:[~2026-11-08  9:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  9:35 [PATCH v3 0/5] sy7636a: power the panel only during updates Pablo Mazzini
2026-11-08  9:35 ` [PATCH v3 2/5] hwmon: sy7636a: fix negative temperatures Pablo Mazzini
2026-11-08  9:39   ` sashiko-bot
2026-11-08 15:59   ` Guenter Roeck
2026-11-08  9:36 ` [PATCH v3 3/5] regulator: sy7636a: bind to the I2C device directly Pablo Mazzini
2026-11-08  9:43   ` sashiko-bot [this message]
2026-11-08 16:02   ` Guenter Roeck
2026-11-08  9:36 ` [PATCH v3 4/5] hwmon: sy7636a: read the temperature only while the rails are on Pablo Mazzini
2026-11-08  9:48   ` sashiko-bot
2026-11-08 14:50   ` Guenter Roeck
2026-11-08 15:40     ` Pablo Mazzini
2026-11-11 17:51 ` (subset) [PATCH v3 0/5] sy7636a: power the panel only during updates Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-203664@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=pmazzini@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox