Re: [PATCH v2 1/3] hwmon: (nct6775) Handle dual use registers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] hwmon: (nct6775) missing Fixes trailers for REG_TARGET
  word-sized bug
--

commit 07bbb498967ba79c83375f58dde7d2cb44db82b2
Author: Anton Lundin <glance@ac2.se>

> hwmon: (nct6775) Handle dual use registers
>
> The REG_TARGET register has different meaning, depending on if pwm is in
> thermal_cruise or speed_cruise.
>
> This means we can't assume it's always word sized, so we need to handle
> it differently depending on which mode we're in.
>
> The code already does this, but the register was configured as word
> sized for the speed_cruise mode, which would do the wrong thing in
> thermal_cruise mode.
>
> Signed-off-by: Anton Lundin <glance@ac2.se>

[Severity: Low]
Since this fixes how REG_TARGET is accessed in thermal_cruise mode on
NCT6106, NCT6116, and NCT6126, should it include Fixes: tags for the
commits that added those entries to nct6775_reg_is_word_sized()?

  Fixes: 6c009501ff20 ("hwmon: (nct6775) Add support for NCT6102D/6106D")
  Fixes: 29c7cb485b32 ("hwmon: (nct6775) Integrate new model nct6116")
  Fixes: 437b3c2a4bdc ("hwmon: (nct6775) Add support for NCT6126D")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109082511.851377-1-glance@ac2.se?part=1