From: sashiko-bot@kernel.org
To: raoxu <raoxu@uniontech.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (scmi) Enable temperature sensors using their sensor IDs
Date: Mon, 09 Nov 2026 08:41:34 +0000 [thread overview]
Message-ID: <sashiko-outbox-204602@kernel.org> (raw)
In-Reply-To: <AED18609B941BCFD+20261109082854.3739085-1-raoxu@uniontech.com>
> From: Xu Rao <raoxu@uniontech.com>
>
> scmi_hwmon_probe() groups sensors by hwmon type, so the index in
> scmi_sensors->info[hwmon_temp] is not necessarily the SCMI sensor ID.
> Passing that index to config_set() targets a different sensor if the
> platform exposes non-temperature sensors ahead of temperature sensors.
> The intended temperature sensor can remain disabled, causing subsequent
> readings to fail. If configuring the wrong sensor fails, thermal
> registration of the intended sensor is also skipped.
>
> Use the firmware sensor ID, as the read and thermal registration paths
> already do, so temperature sensors are enabled correctly.
>
> The patch was reviewed and the commit message expanded with OpenCode
> AI assistance.
>
> Fixes: 72804d1631b3 ("hwmon: (scmi) Enable sensors to assure they can be read")
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/AED18609B941BCFD+20261109082854.3739085-1-raoxu@uniontech.com?part=1
next prev parent reply other threads:[~2026-11-09 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 8:28 [PATCH] hwmon: (scmi) Enable temperature sensors using their sensor IDs raoxu
2026-11-09 8:41 ` sashiko-bot [this message]
2026-11-09 9:40 ` Sudeep Holla
2026-11-09 15:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204602@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).