From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (w83627ehf) Clamp voltage limits before scaling
Date: Mon, 09 Nov 2026 20:02:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-205525@kernel.org> (raw)
In-Reply-To: <20261109092654.5177-1-zhujun2@cmss.chinamobile.com>
> From: zhujun <zhujun2@cmss.chinamobile.com>
>
> in_to_reg() narrows the sysfs value to u32 and multiplies it by 100
> before clamping. A large positive voltage limit can consequently be
> programmed as zero instead of the maximum; 4294967296 mV reproduces this
> on a 64-bit system.
>
> Preserve the input width and clamp to the representable voltage range
> before multiplication.
>
> Developed with assistance from OpenAI Codex.
>
> Fixes: cf0676fe42c8 ("[PATCH] w83627ehf: Add voltage inputs support")
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109092654.5177-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:26 [PATCH] hwmon: (w83627ehf) Clamp voltage limits before scaling Zhu Jun
2026-11-09 20:02 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:48 Zhu Jun
2026-11-11 6:54 ` sashiko-bot
2026-11-11 11:11 ` David Laight
2026-11-11 16:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205525@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox