From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) Clamp voltage limits before narrowing and scaling
Date: Wed, 11 Nov 2026 03:03:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-208152@kernel.org> (raw)
In-Reply-To: <20261111024524.9627-1-zhujun2@cmss.chinamobile.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] hwmon: (nct6775) missing Fixes trailer for in_to_reg() overflow
fix
--
commit 942ff78cd13ea05813c6ab30f0bbe111309ffcdb
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>
> hwmon: (nct6775) Clamp voltage limits before narrowing and scaling
>
> store_in_reg() parses an unsigned long, but in_to_reg() takes a u32 and
> multiplies it by 100 before clamping. Large limits can therefore wrap to
> a low register value. For example, 4294967296 mV becomes zero on a
> 64-bit system.
>
> Keep the input as an unsigned long and bound it to the register range
> before scaling.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
[Severity: Low]
This fixes a bug in in_to_reg() where values parsed by store_in_reg()
can wrap when narrowed and scaled. Should this include:
Fixes: 9de2e2e84e7d ("hwmon: Driver for Nuvoton NCT6775F, NCT6776F, and NCT6779D")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111024524.9627-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-11 3:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 2:45 [PATCH] hwmon: (nct6775) Clamp voltage limits before narrowing and scaling Zhu Jun
2026-11-11 3:03 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 3:36 Zhu Jun
2026-11-11 3:40 ` sashiko-bot
2026-11-11 2:39 Zhu Jun
2026-11-11 2:58 ` sashiko-bot
2026-11-09 9:25 Zhu Jun
2026-11-09 20:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208152@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox