From: sashiko-bot@kernel.org
To: "Davíð Steinn Geirsson" <david@dsg.is>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 3/4] hwmon: (adt7475) Add thermal zone sensor support
Date: Sat, 14 Nov 2026 00:46:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-213946@kernel.org> (raw)
In-Reply-To: <20261114004110.328050-4-david@dsg.is>
> Register the temperature channels as thermal zone sensors. Sensor id N
> is temperature channel N, i.e. temp(N+1). Document this in adt7475.rst.
>
> The hwmon core reads a sensor's temperature while registering the
> thermal zone, from within hwmon_device_register_with_info(). Read the
> chip limits before registering, so that the temperature encoding
> (CONFIG5 two's complement bit) is known for that first read.
>
> With CONFIG_THERMAL_OF, devices that have a devicetree node, or sit
> below one (the hwmon core uses the nearest ancestor's node), see two
> changes:
> - Each temperature channel that no thermal zone uses logs
> "tempN_input not attached to any thermal zone" once at probe.
> - When a thermal zone uses a channel, the hwmon core sets that
> channel's min and max limit registers to the zone's current trip
> window, as it does for other drivers registering thermal sensors.
>
> Signed-off-by: Davíð Steinn Geirsson <david@dsg.is>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114004110.328050-1-david@dsg.is?part=3
next prev parent reply other threads:[~2026-11-14 0:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 0:41 [PATCH 0/4] hwmon: (adt7475) Add thermal sensor and PWM provider support Davíð Steinn Geirsson
2026-11-14 0:41 ` [PATCH 1/4] dt-bindings: hwmon: adt7475: Add #thermal-sensor-cells Davíð Steinn Geirsson
2026-11-14 0:49 ` sashiko-bot
2026-11-14 0:41 ` [PATCH 2/4] hwmon: (adt7475) Convert to hwmon_device_register_with_info() Davíð Steinn Geirsson
2026-11-14 0:56 ` sashiko-bot
2026-11-14 0:41 ` [PATCH 3/4] hwmon: (adt7475) Add thermal zone sensor support Davíð Steinn Geirsson
2026-11-14 0:46 ` sashiko-bot [this message]
2026-11-14 0:41 ` [PATCH 4/4] hwmon: (adt7475) Expose fan control via PWM framework Davíð Steinn Geirsson
2026-11-14 0:51 ` sashiko-bot
2026-11-14 1:03 ` [PATCH 0/4] hwmon: (adt7475) Add thermal sensor and PWM provider support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213946@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=david@dsg.is \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox